From: Sabrina Dubroca <sd@queasysnail.net>
To: Julien Fortin <julien@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, dsa@cumulusnetworks.com
Subject: Re: [PATCH iproute2 json v2 05/27] ip: ipaddress.c: add support for json output
Date: Wed, 20 Sep 2017 15:33:58 +0200 [thread overview]
Message-ID: <20170920133358.GA1073@bistromath.localdomain> (raw)
In-Reply-To: <20170817173614.54987-6-julien@cumulusnetworks.com>
Hi Julien,
2017-08-17, 10:35:52 -0700, Julien Fortin wrote:
> From: Julien Fortin <julien@cumulusnetworks.com>
>
> This patch converts all output (mostly fprintfs) to the new ip_print api
> which handle both regular and json output.
> Initialize a json_writer and open an array object if -json was specified.
> Note that the JSON attribute naming follows the NETLINK_ATTRIBUTE naming.
[snip]
This patch (commit d0e720111aad) changed the output of "ip addr":
Before:
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
After:
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128scope host
valid_lft forever preferred_lft forever
The space following the mask is missing.
Could you have a look?
Thanks.
--
Sabrina
next prev parent reply other threads:[~2017-09-20 13:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 17:35 [PATCH iproute2 json v2 00/27] ip: add -json support to 'ip link show' Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 01/27] color: add new COLOR_NONE and disable_color function Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 02/27] ip: add new command line argument -json (mutually exclusive with -color) Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 03/27] json_writer: add new json handlers (null, float with format, lluint, hu) Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 04/27] ip: ip_print: add new API to print JSON or regular format output Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 05/27] ip: ipaddress.c: add support for json output Julien Fortin
2017-09-20 13:33 ` Sabrina Dubroca [this message]
2017-08-17 17:35 ` [PATCH iproute2 json v2 06/27] ip: iplink.c: open/close json obj for ip -brief -json link show dev DEV Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 07/27] ip: iplink_bond.c: add json output support Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 08/27] ip: iplink_bond_slave.c: add json output support (info_slave_data) Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 09/27] ip: iplink_hsr.c: add json output support Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 10/27] ip: iplink_bridge.c: " Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 11/27] ip: iplink_bridge_slave.c: " Julien Fortin
2017-08-17 17:35 ` [PATCH iproute2 json v2 12/27] ip: iplink_can.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 13/27] ip: iplink_geneve.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 14/27] ip: iplink_ipoib.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 15/27] ip: iplink_ipvlan.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 16/27] ip: iplink_vrf.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 17/27] ip: iplink_vxlan.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 18/27] ip: iplink_xdp.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 19/27] ip: ipmacsec.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 20/27] ip: link_gre.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 21/27] ip: link_gre6.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 22/27] ip: link_ip6tnl.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 23/27] ip: link_iptnl.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 24/27] ip: link_vti.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 25/27] ip: link_vti6.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 26/27] ip: link_macvlan.c: " Julien Fortin
2017-08-17 17:36 ` [PATCH iproute2 json v2 27/27] ip: iplink_vlan.c: " Julien Fortin
2017-08-18 1:04 ` [PATCH iproute2 json v2 00/27] ip: add -json support to 'ip link show' Stephen Hemminger
2017-08-18 7:56 ` Julien Fortin
2017-08-23 21:51 ` Jiri Pirko
2017-08-23 22:03 ` Julien Fortin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920133358.GA1073@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=dsa@cumulusnetworks.com \
--cc=julien@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).