* [PATCH] ipv6: Use ipv6_authlen for len in ipv6_skip_exthdr
@ 2017-09-20 16:18 Xiang Gao
2017-09-20 20:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xiang Gao @ 2017-09-20 16:18 UTC (permalink / raw)
To: trivial, netdev, davem, kuznet, yoshfuji; +Cc: qasdfgtyuiop
In ipv6_skip_exthdr, the lengh of AH header is computed manually
as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro
named ipv6_authlen is already defined for exactly the same job. This
commit replaces the manual computation code with the macro.
Signed-off-by: Xiang Gao <qasdfgtyuiop@gmail.com>
---
net/ipv6/exthdrs_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/exthdrs_core.c b/net/ipv6/exthdrs_core.c
index 305e2ed730bf..115d60919f72 100644
--- a/net/ipv6/exthdrs_core.c
+++ b/net/ipv6/exthdrs_core.c
@@ -99,7 +99,7 @@ int ipv6_skip_exthdr(const struct sk_buff *skb, int start, u8 *nexthdrp,
break;
hdrlen = 8;
} else if (nexthdr == NEXTHDR_AUTH)
- hdrlen = (hp->hdrlen+2)<<2;
+ hdrlen = ipv6_authlen(hp);
else
hdrlen = ipv6_optlen(hp);
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: Use ipv6_authlen for len in ipv6_skip_exthdr
2017-09-20 16:18 [PATCH] ipv6: Use ipv6_authlen for len in ipv6_skip_exthdr Xiang Gao
@ 2017-09-20 20:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-20 20:45 UTC (permalink / raw)
To: qasdfgtyuiop; +Cc: trivial, netdev, kuznet, yoshfuji
From: Xiang Gao <qasdfgtyuiop@gmail.com>
Date: Wed, 20 Sep 2017 12:18:17 -0400
> In ipv6_skip_exthdr, the lengh of AH header is computed manually
> as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro
> named ipv6_authlen is already defined for exactly the same job. This
> commit replaces the manual computation code with the macro.
>
> Signed-off-by: Xiang Gao <qasdfgtyuiop@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-20 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 16:18 [PATCH] ipv6: Use ipv6_authlen for len in ipv6_skip_exthdr Xiang Gao
2017-09-20 20:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).