From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: kys@microsoft.com, netdev@vger.kernel.org, alexng@microsoft.com,
sthemmin@microsoft.com
Subject: Re: [PATCH] hv_netvsc: fix send buffer failure on MTU change
Date: Thu, 21 Sep 2017 15:18:41 -0700 (PDT) [thread overview]
Message-ID: <20170921.151841.2164510833838294238.davem@davemloft.net> (raw)
In-Reply-To: <20170920181735.31316-1-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 20 Sep 2017 11:17:35 -0700
> From: Alex Ng <alexng@microsoft.com>
>
> If MTU is changed the host would reject the send buffer change.
> This problem is result of recent change to allow changing send
> buffer size.
>
> Every time we change the MTU, we store the previous net_device section
> count before destroying the buffer, but we don’t store the previous
> section size. When we reinitialize the buffer, its size is calculated
> by multiplying the previous count and previous size. Since we
> continuously increase the MTU, the host returns us a decreasing count
> value while the section size is reinitialized to 1728 bytes every
> time.
>
> This eventually leads to a condition where the calculated buf_size is
> so small that the host rejects it.
>
> Fixes: 8b5327975ae1 ("netvsc: allow controlling send/recv buffer size")
> Signed-off-by: Alex Ng <alexng@microsoft.com>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied, thank you.
prev parent reply other threads:[~2017-09-21 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 18:17 [PATCH] hv_netvsc: fix send buffer failure on MTU change Stephen Hemminger
2017-09-21 22:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921.151841.2164510833838294238.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexng@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox