netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH net-next 6/7] rtnetlink: link ops lookup must occur with rtnl lock held
Date: Thu, 21 Sep 2017 18:59:01 +0200	[thread overview]
Message-ID: <20170921165902.10746-7-fw@strlen.de> (raw)
In-Reply-To: <20170921165902.10746-1-fw@strlen.de>

all callers meet this requirement, this serves as reminder to not
forget about this in future rtnl pushdown work.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 net/core/rtnetlink.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 7503021fe308..7af9774aec40 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -274,6 +274,8 @@ static const struct rtnl_link_ops *rtnl_link_ops_get(const char *kind)
 {
 	const struct rtnl_link_ops *ops;
 
+	ASSERT_RTNL();
+
 	list_for_each_entry(ops, &link_ops, list) {
 		if (!strcmp(ops->kind, kind))
 			return ops;
@@ -1618,6 +1620,8 @@ static const struct rtnl_link_ops *linkinfo_to_kind_ops(const struct nlattr *nla
 	const struct rtnl_link_ops *ops = NULL;
 	struct nlattr *linfo[IFLA_INFO_MAX + 1];
 
+	ASSERT_RTNL();
+
 	if (nla_parse_nested(linfo, IFLA_INFO_MAX, nla,
 			     ifla_info_policy, NULL) < 0)
 		return NULL;
-- 
2.13.5

  parent reply	other threads:[~2017-09-21 16:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 16:58 [PATCH net-next] rtnetlink: prepare for further rtnl lock pushdown/removal Florian Westphal
2017-09-21 16:58 ` [PATCH net-next 1/7] selftests: rtnetlink.sh: add rudimentary vrf test Florian Westphal
2017-09-21 16:58 ` [PATCH net-next 2/7] rtnetlink: add helper to put master ifindex Florian Westphal
2017-09-21 17:16   ` David Ahern
2017-09-21 16:58 ` [PATCH net-next 3/7] rtnetlink: add helper to dump qdisc name Florian Westphal
2017-09-21 16:58 ` [PATCH net-next 4/7] rtnetlink: add helper to dump ifalias Florian Westphal
2017-09-21 16:59 ` [PATCH net-next 5/7] rtnetlink: add helper to dump vf information Florian Westphal
2017-09-21 17:17   ` David Ahern
2017-09-21 17:25     ` Florian Westphal
2017-09-21 16:59 ` Florian Westphal [this message]
2017-09-21 16:59 ` [PATCH net-next 7/7] rtnetlink: rtnl_have_link_slave_info doesn't need rtnl Florian Westphal
2017-09-21 17:24   ` David Ahern
2017-09-21 17:31     ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170921165902.10746-7-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).