From: David Miller <davem@davemloft.net>
To: josef@toxicpanda.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] fix reuseaddr regression
Date: Fri, 22 Sep 2017 20:40:45 -0700 (PDT) [thread overview]
Message-ID: <20170922.204045.1198472539959809091.davem@davemloft.net> (raw)
In-Reply-To: <1506126008-9148-1-git-send-email-josef@toxicpanda.com>
From: Josef Bacik <josef@toxicpanda.com>
Date: Fri, 22 Sep 2017 20:20:05 -0400
> I introduced a regression when reworking the fastreuse port stuff that allows
> bind conflicts to occur once a reuseaddr successfully opens on an existing tb.
> The root cause is I reversed an if statement which caused us to set the tb as if
> there were no owners on the socket if there were, which obviously is not
> correct.
>
> Dave could you please queue these changes up for -stable, I've run them through
> the net tests and added another test to check for this problem specifically.
Series applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2017-09-23 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 0:20 [PATCH 0/3] fix reuseaddr regression Josef Bacik
2017-09-23 0:20 ` [PATCH 1/3] net: set tb->fast_sk_family Josef Bacik
2017-09-23 0:20 ` [PATCH 2/3] net: use inet6_rcv_saddr to compare sockets Josef Bacik
2017-09-23 0:20 ` [PATCH 3/3] inet: fix improper empty comparison Josef Bacik
2017-09-23 3:40 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-18 16:28 [PATCH 0/3] fix reuseaddr regression josef
2017-09-18 17:44 ` Cole Robinson
2017-09-19 20:50 ` David Miller
2017-09-23 0:28 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922.204045.1198472539959809091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).