From: Josef Bacik <josef@toxicpanda.com>
To: David Miller <davem@davemloft.net>
Cc: josef@toxicpanda.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, crobinso@redhat.com,
labbott@redhat.com, kernel-team@fb.com
Subject: Re: [PATCH 0/3] fix reuseaddr regression
Date: Fri, 22 Sep 2017 20:28:45 -0400 [thread overview]
Message-ID: <20170923002844.slrxaq46zikl3zdn@destiny> (raw)
In-Reply-To: <20170919.135056.44228457394918392.davem@davemloft.net>
On Tue, Sep 19, 2017 at 01:50:56PM -0700, David Miller wrote:
> From: josef@toxicpanda.com
> Date: Mon, 18 Sep 2017 12:28:54 -0400
>
> > I introduced a regression when reworking the fastreuse port stuff that allows
> > bind conflicts to occur once a reuseaddr socket successfully opens on an
> > existing tb. The root cause is I reversed an if statement which caused us to
> > set the tb as if there were no owners on the socket if there were, which
> > obviously is not correct.
> >
> > Dave I have follow up patches that will add a selftest for this case and I ran
> > the other reuseport related tests as well. These need to go in pretty quickly
> > as it breaks kvm, I've marked them for stable. Sorry for the regression,
>
> First, please fix your "From: " field so that it actually has your full
> name rather than just your email address. This matter when I apply
> your patches.
>
> Second, remove the stable CC:. For networking changes, you simply ask
> me to queue the changes up for -stable.
>
Sorry Dave, I've fixed my git email settings and I droped the stable cc and sent
a new round. Didn't see this until just now, my bad.
Josef
next prev parent reply other threads:[~2017-09-23 0:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 16:28 [PATCH 0/3] fix reuseaddr regression josef
2017-09-18 16:28 ` [PATCH 1/3] net: set tb->fast_sk_family josef
2017-09-18 16:28 ` [PATCH 2/3] net: use inet6_rcv_saddr to compare sockets josef
2017-09-18 16:28 ` [PATCH 3/3] inet: fix improper empty comparison josef
2017-09-18 17:44 ` [PATCH 0/3] fix reuseaddr regression Cole Robinson
2017-09-19 20:50 ` David Miller
2017-09-23 0:28 ` Josef Bacik [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-23 0:20 Josef Bacik
2017-09-23 3:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170923002844.slrxaq46zikl3zdn@destiny \
--to=josef@toxicpanda.com \
--cc=crobinso@redhat.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox