From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: felix.manlunas@cavium.com, netdev@vger.kernel.org,
raghu.vatsavayi@cavium.com, derek.chickles@cavium.com,
satananda.burla@cavium.com, manish.awasthi@cavium.com,
veerasenareddy.burru@cavium.com
Subject: Re: [PATCH net-next] liquidio: pass date and time info to NIC firmware
Date: Mon, 25 Sep 2017 20:27:23 -0700 (PDT) [thread overview]
Message-ID: <20170925.202723.162632379860934264.davem@davemloft.net> (raw)
In-Reply-To: <20170923151654.GC21228@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Sat, 23 Sep 2017 17:16:54 +0200
> On Fri, Sep 22, 2017 at 05:35:18PM -0700, Felix Manlunas wrote:
>> From: Veerasenareddy Burru <veerasenareddy.burru@cavium.com>
>
> This is kind of interesting. So you do this once. It could be before
> the RTC driver has probed, so it is 1970. It could be before the NTP
> daemon has started, and so the host clock will later jump, or stretch
> time to gain synchronisation.
>
> It seems like you should be periodically giving the time to the
> firmware, not just once.
Specifically, you really need to send the time/date to the firmware
anytime the system time is updated.
prev parent reply other threads:[~2017-09-26 3:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 0:35 [PATCH net-next] liquidio: pass date and time info to NIC firmware Felix Manlunas
2017-09-23 15:16 ` Andrew Lunn
2017-09-26 3:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925.202723.162632379860934264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=manish.awasthi@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
--cc=veerasenareddy.burru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).