From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: iwlegacy: make const array static to shink object code size Date: Mon, 25 Sep 2017 08:29:49 +0000 (UTC) Message-ID: <20170925082949.EF68E60719@smtp.codeaurora.org> References: <20170921225630.21916-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Stanislaw Gruszka , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Colin Ian King Return-path: In-Reply-To: <20170921225630.21916-1-colin.king@canonical.com> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > > text data bss dec hex filename > 159029 33154 1216 193399 2f377 4965-mac.o > > text data bss dec hex filename > 158122 33250 1216 192588 2f04c 4965-mac.o > > (gcc version 7.2.0 x86_64) > > Signed-off-by: Colin Ian King > Acked-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks. 9b029e178ea1 iwlegacy: make const array static to shink object code size -- https://patchwork.kernel.org/patch/9964889/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches