From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org
Subject: Re: [PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports
Date: Tue, 26 Sep 2017 20:20:21 -0700 (PDT) [thread overview]
Message-ID: <20170926.202021.1637296078204678176.davem@davemloft.net> (raw)
In-Reply-To: <1506464764-12699-8-git-send-email-andrew@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 27 Sep 2017 00:26:04 +0200
> +
> + for (port = 0; port < mv88e6xxx_num_ports(chip); ++port) {
Just a nit pick since you are going to respin this anyways:
for (x; cond(x); x++)
seems to be the canonical way to express this in the kernel, so please
make "++port" into "port++"
Thank you.
next prev parent reply other threads:[~2017-09-27 3:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 22:25 [PATCH net-next 0/6] mv88e6xxx broadcast flooding in hardware Andrew Lunn
2017-09-26 22:25 ` [PATCH net-next 1/6] net: dsa: Fix SWITCHDEV_ATTR_ID_PORT_PARENT_ID Andrew Lunn
2017-09-27 10:15 ` Sergei Shtylyov
2017-09-27 15:31 ` Vivien Didelot
2017-09-26 22:25 ` [PATCH net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets Andrew Lunn
2017-09-27 19:46 ` Florian Fainelli
2017-09-27 20:11 ` Andrew Lunn
2017-09-26 22:26 ` [PATCH net-next 3/6] net: dsa: mv88e6xxx: Fixed port netdev check for VLANs Andrew Lunn
2017-09-26 22:26 ` [PATCH net-next 4/6] net: dsa: mv88e6xxx: Print offending port when vlan check fails Andrew Lunn
2017-09-27 15:49 ` Vivien Didelot
2017-09-26 22:26 ` [PATCH net-next 5/6] net: dsa: mv88e6xxx: Move mv88e6xxx_port_db_load_purge() Andrew Lunn
2017-09-27 15:51 ` Vivien Didelot
2017-09-26 22:26 ` [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware Andrew Lunn
2017-09-27 18:24 ` Vivien Didelot
2017-09-27 18:36 ` Andrew Lunn
2017-09-27 18:59 ` Vivien Didelot
2017-09-27 18:37 ` Florian Fainelli
2017-09-27 18:46 ` Andrew Lunn
2017-09-27 19:19 ` Vivien Didelot
2017-09-27 19:33 ` Florian Fainelli
2017-09-27 20:18 ` Andrew Lunn
2017-09-26 22:26 ` [PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports Andrew Lunn
2017-09-26 22:43 ` Andrew Lunn
2017-09-27 3:20 ` David Miller [this message]
2017-09-27 18:28 ` [PATCH net-next 0/6] mv88e6xxx broadcast flooding in hardware Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926.202021.1637296078204678176.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).