From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: vyasevich@gmail.com, lucien.xin@gmail.com, nhorman@tuxdriver.com,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net v2] sctp: Fix a big endian bug in sctp_diag_dump()
Date: Tue, 26 Sep 2017 21:17:58 -0700 (PDT) [thread overview]
Message-ID: <20170926.211758.629176988425489674.davem@davemloft.net> (raw)
In-Reply-To: <20170925101926.db4f6x4hblh7tcvo@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 25 Sep 2017 13:19:26 +0300
> The sctp_for_each_transport() function takes an pointer to int. The
> cb->args[] array holds longs so it's only using the high 32 bits. It
> works on little endian system but will break on big endian 64 bit
> machines.
>
> Fixes: d25adbeb0cdb ("sctp: fix an use-after-free issue in sctp_sock_dump")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: The v1 patch changed the function to take a long pointer, but v2
> just changes the caller.
Applied, thanks.
prev parent reply other threads:[~2017-09-27 4:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 10:25 [PATCH net] sctp: Fix a big endian bug in sctp_for_each_transport() Dan Carpenter
2017-09-23 11:37 ` Xin Long
2017-09-25 10:19 ` [PATCH net v2] sctp: Fix a big endian bug in sctp_diag_dump() Dan Carpenter
2017-09-25 11:23 ` Neil Horman
2017-09-25 15:00 ` Xin Long
2017-09-27 4:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926.211758.629176988425489674.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).