From: "Yang, Yi" <yi.y.yang@intel.com>
To: Eric Garver <e@erig.me>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dev@openvswitch.org" <dev@openvswitch.org>,
"jbenc@redhat.com" <jbenc@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support
Date: Tue, 26 Sep 2017 13:02:15 +0800 [thread overview]
Message-ID: <20170926050215.GB5896@localhost.localdomain> (raw)
In-Reply-To: <20170925192842.GD1786@dev-rhel7>
On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote:
> On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote:
> > +
> > + length = nsh_hdr_len(nsh_hdr);
> > + skb_pull(skb, length);
>
> Do you need to verify you can actually pull length bytes? I don't see
> any guarantee.
I have added skb length check in pop_nsh, so that can verify this.
> > + err = skb_ensure_writable(skb, skb_network_offset(skb) +
> > + sizeof(struct nshhdr));
>
> This calls pskb_may_pull(), but you're not pulling any data here.
set_ipv4 and set_ipv6 also used skb_ensure_writable to check if skb
has enough header length, they didn't call skb_pull in the following
part, so I think this is ok.
I have sent out v10 to fix all of your comments for v9, please help
review v10, thanks a lot.
next prev parent reply other threads:[~2017-09-26 5:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 14:16 [PATCH net-next v9] openvswitch: enable NSH support Yi Yang
2017-09-25 18:14 ` Jiri Benc
2017-09-26 4:55 ` Yang, Yi
2017-09-26 10:49 ` Jiri Benc
2017-09-27 1:39 ` Yang, Yi
2017-09-28 18:28 ` Pravin Shelar
2017-09-29 6:40 ` Yang, Yi
2017-09-29 7:10 ` Jan Scheurich
[not found] ` <CFF8EF42F1132E4CBE2BF0AB6C21C58D7881A337-hqolJogE5njKJFWPz4pdheaU1rCVNFv4@public.gmane.org>
2017-09-29 7:15 ` Yang, Yi
[not found] ` <20170929071553.GA19053-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-09-29 7:27 ` Jan Scheurich
2017-09-25 19:28 ` [ovs-dev] " Eric Garver
2017-09-26 5:02 ` Yang, Yi [this message]
2017-09-26 20:59 ` Eric Garver
2017-09-27 1:09 ` Yang, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926050215.GB5896@localhost.localdomain \
--to=yi.y.yang@intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=e@erig.me \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).