From: Jiri Benc <jbenc@redhat.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Simon Horman <simon.horman@netronome.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Linux Netdev List <netdev@vger.kernel.org>,
oss-drivers@netronome.com,
John Hurley <john.hurley@netronome.com>,
Paolo Abeni <pabeni@redhat.com>, Paul Blakey <paulb@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>, Roi Dayan <roid@mellanox.com>
Subject: Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload
Date: Tue, 26 Sep 2017 16:31:35 +0200 [thread overview]
Message-ID: <20170926163135.36d14a72@griffin> (raw)
In-Reply-To: <CAJ3xEMjOkF7vKHY=+q1dHXGdsyEXFPUa6dsGD_-M3+TX=DNouA@mail.gmail.com>
On Tue, 26 Sep 2017 17:17:02 +0300, Or Gerlitz wrote:
> maybe before/instead you call it a bug,
But it is a bug. When offloaded, the rules must not behave differently.
That's the fundamental thing about offloading. Here, the rules behave
differently when offloaded and when not. That's a bug.
> take a look on the design there and maybe
> tell us how to possibly do that otherwise?
I don't know the design. It's the responsibility of those who implement
the offloading to do it in the way that it's consistent with the
software path. That has always been the case.
This needs to be fixed. If it can't be fixed, the feature needs to be
reverted. It's not that Linux has to make use of every single offload
supported by hardware. If the offloading cannot be fit into how Linux
works, then the offload can't be supported. There are in fact many
precedents.
Jiri
next prev parent reply other threads:[~2017-09-26 14:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 10:23 [PATCH net-next 0/7] nfp: flower vxlan tunnel offload Simon Horman
2017-09-25 10:23 ` [PATCH net-next 1/7] nfp: add helper to get flower cmsg length Simon Horman
2017-09-25 10:23 ` [PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields Simon Horman
2017-09-25 18:35 ` Or Gerlitz
2017-09-26 13:58 ` John Hurley
2017-09-26 14:12 ` Or Gerlitz
2017-09-26 15:11 ` John Hurley
2017-09-26 15:33 ` Or Gerlitz
2017-09-26 15:39 ` John Hurley
2017-09-25 10:23 ` [PATCH net-next 3/7] nfp: compile flower vxlan tunnel set actions Simon Horman
2017-09-25 10:23 ` [PATCH net-next 4/7] nfp: offload flower vxlan endpoint MAC addresses Simon Horman
2017-09-25 10:23 ` [PATCH net-next 5/7] nfp: offload vxlan IPv4 endpoints of flower rules Simon Horman
2017-09-25 10:23 ` [PATCH net-next 6/7] nfp: flower vxlan neighbour offload Simon Horman
2017-09-25 10:23 ` [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive Simon Horman
2017-09-25 18:32 ` Or Gerlitz
[not found] ` <CAK+XE=mVKbAqYwSYvLb0y48O9D-Oq+B_bks7c9iwjsm0j7oYvw@mail.gmail.com>
2017-09-26 9:37 ` John Hurley
2017-09-26 12:44 ` Or Gerlitz
2017-09-25 11:00 ` [PATCH net-next 0/7] nfp: flower vxlan tunnel offload Jakub Kicinski
2017-09-25 15:25 ` Or Gerlitz
2017-09-25 17:04 ` Simon Horman
2017-09-26 10:15 ` Jiri Benc
2017-09-26 12:41 ` Or Gerlitz
2017-09-26 12:51 ` Jiri Benc
2017-09-26 14:17 ` Or Gerlitz
2017-09-26 14:31 ` Jiri Benc [this message]
2017-09-26 14:50 ` Paolo Abeni
2017-09-27 7:40 ` Jiri Pirko
2017-09-27 4:29 ` David Miller
2017-09-27 7:27 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926163135.36d14a72@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pabeni@redhat.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).