* [PATCH] net-ipv6: remove unused IP6_ECN_clear() function
@ 2017-09-27 3:37 Maciej Żenczykowski
2017-09-28 17:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Maciej Żenczykowski @ 2017-09-27 3:37 UTC (permalink / raw)
To: Maciej Żenczykowski, David S . Miller; +Cc: netdev
From: Maciej Żenczykowski <maze@google.com>
This function is unused, and furthermore it is buggy since it suffers
from the same issue that requires IP6_ECN_set_ce() to take a pointer
to the skb so that it may (in case of CHECKSUM_COMPLETE) update skb->csum
Instead of fixing it, let's just outright remove it.
Tested: builds, and 'git grep IP6_ECN_clear' comes up empty
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
include/net/inet_ecn.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/net/inet_ecn.h b/include/net/inet_ecn.h
index dce2d586d9ce..f5ff16d72fe6 100644
--- a/include/net/inet_ecn.h
+++ b/include/net/inet_ecn.h
@@ -133,11 +133,6 @@ static inline int IP6_ECN_set_ce(struct sk_buff *skb, struct ipv6hdr *iph)
return 1;
}
-static inline void IP6_ECN_clear(struct ipv6hdr *iph)
-{
- *(__be32*)iph &= ~htonl(INET_ECN_MASK << 20);
-}
-
static inline void ipv6_copy_dscp(unsigned int dscp, struct ipv6hdr *inner)
{
dscp &= ~INET_ECN_MASK;
--
2.14.1.992.g2c7b836f3a-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net-ipv6: remove unused IP6_ECN_clear() function
2017-09-27 3:37 [PATCH] net-ipv6: remove unused IP6_ECN_clear() function Maciej Żenczykowski
@ 2017-09-28 17:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-28 17:48 UTC (permalink / raw)
To: zenczykowski; +Cc: maze, netdev
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Tue, 26 Sep 2017 20:37:22 -0700
> From: Maciej Żenczykowski <maze@google.com>
>
> This function is unused, and furthermore it is buggy since it suffers
> from the same issue that requires IP6_ECN_set_ce() to take a pointer
> to the skb so that it may (in case of CHECKSUM_COMPLETE) update skb->csum
>
> Instead of fixing it, let's just outright remove it.
>
> Tested: builds, and 'git grep IP6_ECN_clear' comes up empty
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-28 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 3:37 [PATCH] net-ipv6: remove unused IP6_ECN_clear() function Maciej Żenczykowski
2017-09-28 17:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).