From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools Date: Wed, 27 Sep 2017 09:10:50 +0200 Message-ID: <20170927091050.469a3e08@redhat.com> References: <4bdb49b4387d698443e32b8a6a85414e57ef4de0.1506297988.git.daniel@iogearbox.net> <20170927090315.22070171@brouer.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, alexei.starovoitov@gmail.com, john.fastabend@gmail.com, peter.waskiewicz.jr@intel.com, jakub.kicinski@netronome.com, netdev@vger.kernel.org, brouer@redhat.com To: Daniel Borkmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59050 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbdI0HK4 (ORCPT ); Wed, 27 Sep 2017 03:10:56 -0400 In-Reply-To: <20170927090315.22070171@brouer.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 27 Sep 2017 09:03:34 +0200 Jesper Dangaard Brouer wrote: > On Mon, 25 Sep 2017 02:25:52 +0200 > Daniel Borkmann wrote: > > > Looks like a couple of updates missed to get carried into tools/include/uapi/, > > so copy the bpf.h header as usual to pull in latest updates. > > > > Signed-off-by: Daniel Borkmann > > Acked-by: Alexei Starovoitov > > Acked-by: John Fastabend > > --- > > tools/include/uapi/linux/bpf.h | 45 ++++++++++++++++++++++++++++++------------ > > 1 file changed, 32 insertions(+), 13 deletions(-) > > > > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h > > index 461811e..e43491a 100644 > > --- a/tools/include/uapi/linux/bpf.h > > +++ b/tools/include/uapi/linux/bpf.h > > @@ -143,12 +143,6 @@ enum bpf_attach_type { > > > > #define MAX_BPF_ATTACH_TYPE __MAX_BPF_ATTACH_TYPE > > > > -enum bpf_sockmap_flags { > > - BPF_SOCKMAP_UNSPEC, > > - BPF_SOCKMAP_STRPARSER, > > - __MAX_BPF_SOCKMAP_FLAG > > -}; > > - > > Why does "bpf_sockmap_flags" gets removed? > > It got added in: commit 69e8cc134bcb ("bpf: sockmap sample program"). > But I cannot find any users of these flags, so I guess it is okay. Found the explanation in commit 2f857d04601 ("bpf: sockmap, remove STRPARSER map_flags and add multi-map support"). https://git.kernel.org/torvalds/c/2f857d04601 Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer