From: David Miller <davem@davemloft.net>
To: yanhaishuang@cmss.chinamobile.com
Cc: kuznet@ms2.inr.ac.ru, edumazet@google.com, weiwan@google.com,
lucab@debian.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] ipv4: Namespaceify tcp_fastopen_key knob
Date: Thu, 28 Sep 2017 10:47:54 -0700 (PDT) [thread overview]
Message-ID: <20170928.104754.977799185628171706.davem@davemloft.net> (raw)
In-Reply-To: <1506483343-11544-3-git-send-email-yanhaishuang@cmss.chinamobile.com>
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Wed, 27 Sep 2017 11:35:42 +0800
> Different namespace application might require different tcp_fastopen_key
> independently of the host.
>
> David Miller pointed out there is a leak without releasing the context
> of tcp_fastopen_key during netns teardown. So add the release action in
> exit_batch path.
>
> Tested:
> 1. Container namespace:
> # cat /proc/sys/net/ipv4/tcp_fastopen_key:
> 2817fff2-f803cf97-eadfd1f3-78c0992b
>
> cookie key in tcp syn packets:
> Fast Open Cookie
> Kind: TCP Fast Open Cookie (34)
> Length: 10
> Fast Open Cookie: 1e5dd82a8c492ca9
>
> 2. Host:
> # cat /proc/sys/net/ipv4/tcp_fastopen_key:
> 107d7c5f-68eb2ac7-02fb06e6-ed341702
>
> cookie key in tcp syn packets:
> Fast Open Cookie
> Kind: TCP Fast Open Cookie (34)
> Length: 10
> Fast Open Cookie: e213c02bf0afbc8a
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Applied.
next prev parent reply other threads:[~2017-09-28 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 3:35 [PATCH v5 1/4] ipv4: Namespaceify tcp_fastopen knob Haishuang Yan
2017-09-27 3:35 ` [PATCH v5 2/4] ipv4: Remove the 'publish' logic in tcp_fastopen_init_key_once Haishuang Yan
2017-09-28 17:47 ` David Miller
2017-09-27 3:35 ` [PATCH v5 3/4] ipv4: Namespaceify tcp_fastopen_key knob Haishuang Yan
2017-09-28 17:47 ` David Miller [this message]
2017-09-27 3:35 ` [PATCH v5 4/4] ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob Haishuang Yan
2017-09-28 17:48 ` David Miller
2017-09-28 17:47 ` [PATCH v5 1/4] ipv4: Namespaceify tcp_fastopen knob David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928.104754.977799185628171706.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lucab@debian.org \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).