From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org, Thomas Haller <thaller@redhat.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [iproute PATCH] ip-route: Fix for listing routes with RTAX_LOCK attribute
Date: Fri, 29 Sep 2017 12:02:56 -0700 [thread overview]
Message-ID: <20170929120256.79894617@xeon-e3> (raw)
In-Reply-To: <20170928173356.17892-1-phil@nwl.cc>
On Thu, 28 Sep 2017 19:33:56 +0200
Phil Sutter <phil@nwl.cc> wrote:
> This fixes a corner-case for routes with a certain metric locked to
> zero:
>
> | ip route add 192.168.7.0/24 dev eth0 window 0
> | ip route add 192.168.7.0/24 dev eth0 window lock 0
>
> Since the kernel doesn't dump the attribute if it is zero, both routes
> added above would appear as if they were equal although they are not.
>
> Fix this by taking mxlock value for the given metric into account before
> skipping it if it is not present.
>
> Reported-by: Thomas Haller <thaller@redhat.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Looks good, Applied. Thanks Phil
prev parent reply other threads:[~2017-09-29 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 17:33 [iproute PATCH] ip-route: Fix for listing routes with RTAX_LOCK attribute Phil Sutter
2017-09-29 19:02 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929120256.79894617@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox