From: Jakub Kicinski <kubakici@wp.pl>
To: Martin KaFai Lau <kafai@fb.com>
Cc: <netdev@vger.kernel.org>, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>
Subject: Re: [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info
Date: Fri, 29 Sep 2017 19:52:21 -0700 [thread overview]
Message-ID: <20170929195221.732aab55@cakuba> (raw)
In-Reply-To: <20170930023518.bmc6dbpnz27wunod@kafai-mbp>
On Fri, 29 Sep 2017 19:35:18 -0700, Martin KaFai Lau wrote:
> On Sat, Sep 30, 2017 at 02:07:46AM +0000, Jakub Kicinski wrote:
> > Hi Martin!
> >
> > On Wed, 27 Sep 2017 14:37:53 -0700, Martin KaFai Lau wrote:
> > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> > > index 33ccc474fb04..252f4bc9eb25 100644
> > > --- a/include/linux/bpf.h
> > > +++ b/include/linux/bpf.h
> > > @@ -56,6 +56,7 @@ struct bpf_map {
> > > struct work_struct work;
> > > atomic_t usercnt;
> > > struct bpf_map *inner_map_meta;
> > > + u8 name[BPF_OBJ_NAME_LEN];
> >
> > Any reason not to use plain char? I was looking at adding names to
> > bpftool and:
> Happy to have early user :)
The newly exposed info is so useful I couldn't resist :)
> It was mostly due to my early idea on treating the name as
> a blob without much char checking, which was then trashed
> but did not reflect that here.
>
> I will make a followup patch later.
Awesome, thanks!
next prev parent reply other threads:[~2017-09-30 2:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 21:37 [PATCH net-next 0/5] bpf: Extend bpf_{prog,map}_info Martin KaFai Lau
2017-09-27 21:37 ` [PATCH net-next 1/5] bpf: Add name, load_time, uid and map_ids to bpf_prog_info Martin KaFai Lau
2017-09-27 21:37 ` [PATCH net-next 2/5] bpf: Add map_name to bpf_map_info Martin KaFai Lau
2017-09-30 2:07 ` Jakub Kicinski
2017-09-30 2:35 ` Martin KaFai Lau
2017-09-30 2:52 ` Jakub Kicinski [this message]
2017-09-27 21:37 ` [PATCH net-next 3/5] bpf: libbpf: Provide basic API support to specify BPF obj name Martin KaFai Lau
2017-09-27 21:37 ` [PATCH net-next 4/5] bpf: Swap the order of checking prog_info and map_info Martin KaFai Lau
2017-09-27 21:37 ` [PATCH net-next 5/5] bpf: Test new fields in bpf_attr and bpf_{prog,map}_info Martin KaFai Lau
2017-09-29 5:17 ` [PATCH net-next 0/5] bpf: Extend bpf_{prog,map}_info David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929195221.732aab55@cakuba \
--to=kubakici@wp.pl \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).