* [PATCH net] ppp: fix __percpu annotation
@ 2017-09-28 15:57 Guillaume Nault
2017-10-01 2:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Nault @ 2017-09-28 15:57 UTC (permalink / raw)
To: netdev; +Cc: Gao Feng, Paul Mackerras
Move sparse annotation right after pointer type.
Fixes sparse warning:
drivers/net/ppp/ppp_generic.c:1422:13: warning: incorrect type in initializer (different address spaces)
drivers/net/ppp/ppp_generic.c:1422:13: expected void const [noderef] <asn:3>*__vpp_verify
drivers/net/ppp/ppp_generic.c:1422:13: got int *<noident>
...
Fixes: e5dadc65f9e0 ("ppp: Fix false xmit recursion detect with two ppp devices")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
---
drivers/net/ppp/ppp_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index a404552555d4..c3f77e3b7819 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -120,7 +120,7 @@ struct ppp {
int n_channels; /* how many channels are attached 54 */
spinlock_t rlock; /* lock for receive side 58 */
spinlock_t wlock; /* lock for transmit side 5c */
- int *xmit_recursion __percpu; /* xmit recursion detect */
+ int __percpu *xmit_recursion; /* xmit recursion detect */
int mru; /* max receive unit 60 */
unsigned int flags; /* control bits 64 */
unsigned int xstate; /* transmit state bits 68 */
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] ppp: fix __percpu annotation
2017-09-28 15:57 [PATCH net] ppp: fix __percpu annotation Guillaume Nault
@ 2017-10-01 2:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-10-01 2:58 UTC (permalink / raw)
To: g.nault; +Cc: netdev, gfree.wind, paulus
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Thu, 28 Sep 2017 17:57:58 +0200
> Move sparse annotation right after pointer type.
>
> Fixes sparse warning:
> drivers/net/ppp/ppp_generic.c:1422:13: warning: incorrect type in initializer (different address spaces)
> drivers/net/ppp/ppp_generic.c:1422:13: expected void const [noderef] <asn:3>*__vpp_verify
> drivers/net/ppp/ppp_generic.c:1422:13: got int *<noident>
> ...
>
> Fixes: e5dadc65f9e0 ("ppp: Fix false xmit recursion detect with two ppp devices")
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-01 2:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-28 15:57 [PATCH net] ppp: fix __percpu annotation Guillaume Nault
2017-10-01 2:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).