netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch net-next 0/2] mlxsw: Fixlets
@ 2017-10-02 10:21 Jiri Pirko
  2017-10-02 10:21 ` [patch net-next 1/2] mlxsw: spectrum_router: Fix a typo Jiri Pirko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jiri Pirko @ 2017-10-02 10:21 UTC (permalink / raw)
  To: netdev; +Cc: davem, petrm, idosch, mlxsw

From: Jiri Pirko <jiri@mellanox.com>

Couple of small nit fixes from Petr

Petr Machata (2):
  mlxsw: spectrum_router: Fix a typo
  mlxsw: spectrum_router: Drop a redundant condition

 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.9.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [patch net-next 1/2] mlxsw: spectrum_router: Fix a typo
  2017-10-02 10:21 [patch net-next 0/2] mlxsw: Fixlets Jiri Pirko
@ 2017-10-02 10:21 ` Jiri Pirko
  2017-10-02 10:21 ` [patch net-next 2/2] mlxsw: spectrum_router: Drop a redundant condition Jiri Pirko
  2017-10-02 18:20 ` [patch net-next 0/2] mlxsw: Fixlets David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2017-10-02 10:21 UTC (permalink / raw)
  To: netdev; +Cc: davem, petrm, idosch, mlxsw

From: Petr Machata <petrm@mellanox.com>

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index ef4b86b..75078a3 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -1680,7 +1680,7 @@ __mlxsw_sp_router_neighs_update_rauhtd(struct mlxsw_sp *mlxsw_sp,
 		err = mlxsw_reg_query(mlxsw_sp->core, MLXSW_REG(rauhtd),
 				      rauhtd_pl);
 		if (err) {
-			dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to dump neighbour talbe\n");
+			dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to dump neighbour table\n");
 			break;
 		}
 		num_rec = mlxsw_reg_rauhtd_num_rec_get(rauhtd_pl);
-- 
2.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [patch net-next 2/2] mlxsw: spectrum_router: Drop a redundant condition
  2017-10-02 10:21 [patch net-next 0/2] mlxsw: Fixlets Jiri Pirko
  2017-10-02 10:21 ` [patch net-next 1/2] mlxsw: spectrum_router: Fix a typo Jiri Pirko
@ 2017-10-02 10:21 ` Jiri Pirko
  2017-10-02 18:20 ` [patch net-next 0/2] mlxsw: Fixlets David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2017-10-02 10:21 UTC (permalink / raw)
  To: netdev; +Cc: davem, petrm, idosch, mlxsw

From: Petr Machata <petrm@mellanox.com>

Signed-off-by: Petr Machata <petrm@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 75078a3..58bc04c 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -3251,7 +3251,7 @@ mlxsw_sp_fib_entry_offload_refresh(struct mlxsw_sp_fib_entry *fib_entry,
 			return;
 		if (mlxsw_sp_fib_entry_should_offload(fib_entry))
 			mlxsw_sp_fib_entry_offload_set(fib_entry);
-		else if (!mlxsw_sp_fib_entry_should_offload(fib_entry))
+		else
 			mlxsw_sp_fib_entry_offload_unset(fib_entry);
 		return;
 	default:
-- 
2.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch net-next 0/2] mlxsw: Fixlets
  2017-10-02 10:21 [patch net-next 0/2] mlxsw: Fixlets Jiri Pirko
  2017-10-02 10:21 ` [patch net-next 1/2] mlxsw: spectrum_router: Fix a typo Jiri Pirko
  2017-10-02 10:21 ` [patch net-next 2/2] mlxsw: spectrum_router: Drop a redundant condition Jiri Pirko
@ 2017-10-02 18:20 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-10-02 18:20 UTC (permalink / raw)
  To: jiri; +Cc: netdev, petrm, idosch, mlxsw

From: Jiri Pirko <jiri@resnulli.us>
Date: Mon,  2 Oct 2017 12:21:56 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Couple of small nit fixes from Petr

Series applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-02 18:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 10:21 [patch net-next 0/2] mlxsw: Fixlets Jiri Pirko
2017-10-02 10:21 ` [patch net-next 1/2] mlxsw: spectrum_router: Fix a typo Jiri Pirko
2017-10-02 10:21 ` [patch net-next 2/2] mlxsw: spectrum_router: Drop a redundant condition Jiri Pirko
2017-10-02 18:20 ` [patch net-next 0/2] mlxsw: Fixlets David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).