From: David Miller <davem@davemloft.net>
To: shmulik@nsof.io
Cc: netdev@vger.kernel.org, mateusz.bajorski@nokia.com,
dsa@cumulusnetworks.com, tgraf@suug.ch,
shmulik.ladkani@gmail.com
Subject: Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match
Date: Tue, 03 Oct 2017 14:54:18 -0700 (PDT) [thread overview]
Message-ID: <20171003.145418.677435703318514230.davem@davemloft.net> (raw)
In-Reply-To: <20170930085909.1103-1-shmulik@nsof.io>
From: Shmulik Ladkani <shmulik@nsof.io>
Date: Sat, 30 Sep 2017 11:59:09 +0300
> This leads to inconsistencies, depending on order of operations, e.g.:
I don't see any inconsistency. When you insert using NLM_F_EXCL the
insertion fails if any existing rule matches or overlaps in any way
with the keys in the new rule.
Sorry I'm not going to apply this.
next prev parent reply other threads:[~2017-10-03 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 8:59 [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match Shmulik Ladkani
2017-10-03 21:54 ` David Miller [this message]
2017-10-04 3:58 ` Eyal Birger
2017-10-04 4:40 ` David Ahern
2017-10-04 5:34 ` Shmulik Ladkani
-- strict thread matches above, loose matches on Subject: below --
2017-10-07 6:04 Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003.145418.677435703318514230.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=mateusz.bajorski@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
--cc=shmulik@nsof.io \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).