From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] fsl/fman: remove of_node Date: Tue, 03 Oct 2017 21:43:57 -0700 (PDT) Message-ID: <20171003.214357.2276688669726195045.davem@davemloft.net> References: <1506940297-20442-1-git-send-email-madalin.bucur@nxp.com> <20171002.160445.737065995396076298.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, linux-kernel@vger.kernel.org To: madalin.bucur@nxp.com Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Madalin-cristian Bucur Date: Tue, 3 Oct 2017 08:49:31 +0000 > My patch removes the of_node that was set to a device that was not an > of_device, preventing duplicated probing of both the real of_device > and the "fake" one created through this assignment. > > I understand that the DSA issue that triggered the initial change > was related to DSA finding the network devices using > of_find_net_device_by_node(), something that will not work for the > DPAA case where the netdevice does not have an of_node. I do not know > enough about DSA to come up with a solution for this problem now. > Andrew, Florian, can you please comment on this? It sounds like you're knowingly breaking DSA.