From: David Miller <davem@davemloft.net>
To: stefanha@redhat.com
Cc: netdev@vger.kernel.org, jhansen@vmware.com, decui@microsoft.com
Subject: Re: [PATCH 5/5] VSOCK: add tools/vsock/vsock_diag_test
Date: Tue, 03 Oct 2017 21:48:05 -0700 (PDT) [thread overview]
Message-ID: <20171003.214805.176732000485014040.davem@davemloft.net> (raw)
In-Reply-To: <20171003153943.23159-6-stefanha@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Tue, 3 Oct 2017 11:39:43 -0400
> MAINTAINERS | 1 +
> tools/vsock/Makefile | 9 +
> tools/vsock/control.h | 13 +
> tools/vsock/timeout.h | 14 +
> tools/vsock/control.c | 219 ++++++++++++++
> tools/vsock/timeout.c | 64 ++++
> tools/vsock/vsock_diag_test.c | 681 ++++++++++++++++++++++++++++++++++++++++++
> tools/vsock/.gitignore | 2 +
Please don't create you own "special" directory for tests.
Tests belong under tools/testing/selftests/
If you put your tests in the proper place, and structure them properly (especially
the Makefile rules), they will automatically be run by various automated build
and test frameworks.
next prev parent reply other threads:[~2017-10-04 4:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:39 [PATCH 0/5] VSOCK: add sock_diag interface Stefan Hajnoczi
2017-10-03 15:39 ` [PATCH 1/5] VSOCK: export socket tables for " Stefan Hajnoczi
2017-10-03 15:39 ` [PATCH 2/5] VSOCK: export __vsock_in_bound/connected_table() Stefan Hajnoczi
2017-10-04 4:46 ` David Miller
2017-10-04 15:05 ` Stefan Hajnoczi
2017-10-03 15:39 ` [PATCH 3/5] VSOCK: use TCP state constants for sk_state Stefan Hajnoczi
2017-10-03 15:39 ` [PATCH 4/5] VSOCK: add sock_diag interface Stefan Hajnoczi
2017-10-04 4:46 ` David Miller
2017-10-04 15:05 ` Stefan Hajnoczi
2017-10-03 15:39 ` [PATCH 5/5] VSOCK: add tools/vsock/vsock_diag_test Stefan Hajnoczi
2017-10-04 4:48 ` David Miller [this message]
2017-10-04 15:05 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003.214805.176732000485014040.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=jhansen@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).