From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
nikolay@cumulusnetworks.com, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood
Date: Tue, 3 Oct 2017 11:29:48 -0700 [thread overview]
Message-ID: <20171003112948.44d9cc56@xeon-e3> (raw)
In-Reply-To: <1507054876-16746-2-git-send-email-roopa@cumulusnetworks.com>
On Tue, 3 Oct 2017 11:21:14 -0700
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
> index 48fb174..7a50dc5 100644
> --- a/net/bridge/br_forward.c
> +++ b/net/bridge/br_forward.c
> @@ -204,7 +204,8 @@ void br_flood(struct net_bridge *br, struct sk_buff *skb,
> /* Do not flood to ports that enable proxy ARP */
> if (p->flags & BR_PROXYARP)
> continue;
> - if ((p->flags & BR_PROXYARP_WIFI) &&
> + if ((p->flags & BR_PROXYARP_WIFI ||
> + p->flags & BR_NEIGH_SUPPRESS) &&
> BR_INPUT_SKB_CB(skb)->proxyarp_replied)
> continue;
Don;t you need additional paren here to avoid warnings.
Or do one mask:
if ((p->flags & (BR_PROXYARP_WIFI | BR_NEIGH_SUPPRESS)) &&
BR_INPUT_SKB_CB(skb)->proxyarp_replied)
continue;
next prev parent reply other threads:[~2017-10-03 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 18:21 [PATCH net-next v2 0/3] bridge: neigh msg proxy and flood suppression support Roopa Prabhu
2017-10-03 18:21 ` [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood Roopa Prabhu
2017-10-03 18:29 ` Stephen Hemminger [this message]
2017-10-04 4:47 ` Roopa Prabhu
2017-10-03 18:21 ` [PATCH net-next v2 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports Roopa Prabhu
2017-10-03 18:21 ` [PATCH net-next v2 3/3] bridge: suppress nd " Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003112948.44d9cc56@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).