From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: dsa: lan9303: make functions lan9303_mdio_phy_{read|write} static Date: Tue, 3 Oct 2017 14:41:45 +0200 Message-ID: <20171003124145.GE13548@lunn.ch> References: <20171003103918.26934-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Colin King Return-path: Content-Disposition: inline In-Reply-To: <20171003103918.26934-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Oct 03, 2017 at 11:39:18AM +0100, Colin King wrote: > From: Colin Ian King > > The functions lan9303_mdio_phy_write and lan9303_mdio_phy_read are local > to the source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'lan9303_mdio_phy_write' was not declared. Should it be static? > symbol 'lan9303_mdio_phy_read' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Andrew Lunn Andrew