From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver Date: Tue, 3 Oct 2017 22:53:59 +0200 Message-ID: <20171003205359.GH30045@lunn.ch> References: <20171003000442.31841-1-troy.kisky@boundarydevices.com> <20171003005148.GA24147@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: shawn.guo@linaro.org, fugang.duan@nxp.com, netdev@vger.kernel.org, davem@davemloft.net, fabio.estevam@nxp.com, lznuaa@gmail.com To: Troy Kisky Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:38126 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbdJCUyD (ORCPT ); Tue, 3 Oct 2017 16:54:03 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 03, 2017 at 01:41:34PM -0700, Troy Kisky wrote: > On 10/2/2017 5:51 PM, Andrew Lunn wrote: > > On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote: > >> imx7s/imx7d has the ptp interrupt newly added as well. > >> This will allow the ptp interrupt to have its own interrupt routine. > >> > >> Signed-off-by: Troy Kisky > >> --- > >> arch/arm/boot/dts/imx6qdl.dtsi | 1 + > >> arch/arm/boot/dts/imx6sx.dtsi | 2 ++ > >> arch/arm/boot/dts/imx6ul.dtsi | 2 ++ > >> arch/arm/boot/dts/imx7d.dtsi | 4 +++- > >> arch/arm/boot/dts/imx7s.dtsi | 4 +++- > >> 5 files changed, 11 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > >> index 8884b4a3cafb..d848d2bfe8e2 100644 > >> --- a/arch/arm/boot/dts/imx6qdl.dtsi > >> +++ b/arch/arm/boot/dts/imx6qdl.dtsi > >> @@ -1017,6 +1017,7 @@ > >> fec: ethernet@02188000 { > >> compatible = "fsl,imx6q-fec"; > >> reg = <0x02188000 0x4000>; > >> + interrupt-names = "","ptp"; > > > > Hi Troy > > > > The "" looks a bit odd. Can you use a name here? > > > > Andrew > > > > Sure. Can I use "q0","q1","q2", and look them up by name in fec_main > as well ? Hi Troy Is there no better name? How does the datasheet name them? > Should I worrying about compatiblity with old dtbs ? Yes. You cannot break old dtb blobs. So i would suggest keep looking up the old interrupts by number. But this new interrupt you can use the name. Andrew