From: David Miller <davem@davemloft.net>
To: mka@chromium.org
Cc: jakub.kicinski@netronome.com, simon.horman@netronome.com,
dirk.vandermerwe@netronome.com, oss-drivers@netronome.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
renato.golin@linaro.org, manojgupta@chromium.org,
groeck@chromium.org, dianders@chromium.org
Subject: Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro
Date: Wed, 04 Oct 2017 10:44:30 -0700 (PDT) [thread overview]
Message-ID: <20171004.104430.371058999122748879.davem@davemloft.net> (raw)
In-Reply-To: <20171004174215.GM173745@google.com>
From: Matthias Kaehlcke <mka@chromium.org>
Date: Wed, 4 Oct 2017 10:42:15 -0700
> Given that this doesn't seem to be a widespread issue in the kernel
> personally I would consider the conversion to a macro in this case an
> acceptable solution, though it is definitely ugly. However I'm not the
> owner of the driver or the subsystem, so my opinion doesn't really
> carry much weight here ;-)
Losing type checking is a serious regression as far as I am concerned.
next prev parent reply other threads:[~2017-10-04 17:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 20:05 [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro Matthias Kaehlcke
2017-10-03 21:50 ` Jakub Kicinski
2017-10-04 17:42 ` Matthias Kaehlcke
2017-10-04 17:44 ` David Miller [this message]
[not found] ` <CAAMbb05G=HBQweiWqYva_9zTnQqAcwMhJ0yYBUi26T04YA4CxQ@mail.gmail.com>
2017-10-04 18:17 ` Jakub Kicinski
2017-10-04 18:44 ` Matthias Kaehlcke
2017-10-24 16:56 ` Matthias Kaehlcke
2017-10-24 17:03 ` Jakub Kicinski
2017-10-24 17:13 ` Matthias Kaehlcke
2017-10-04 18:07 ` Joe Perches
2017-10-04 18:49 ` Matthias Kaehlcke
2017-10-04 22:22 ` Jakub Kicinski
2017-10-04 23:16 ` Matthias Kaehlcke
2017-10-04 23:25 ` Jakub Kicinski
2017-10-05 0:38 ` Manoj Gupta
2017-10-05 0:56 ` Jakub Kicinski
2017-10-05 1:50 ` Manoj Gupta
2017-10-05 2:06 ` Jakub Kicinski
2017-10-05 2:13 ` Manoj Gupta
2017-10-09 17:29 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004.104430.371058999122748879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=dirk.vandermerwe@netronome.com \
--cc=groeck@chromium.org \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@chromium.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=renato.golin@linaro.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).