From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
daniel@iogearbox.net, dsahern@gmail.com, netdev@vger.kernel.org,
oss-drivers@netronome.com, david.beckett@netronome.com
Subject: Re: [RFC] bpf: remove global verifier state
Date: Tue, 3 Oct 2017 20:43:13 -0700 [thread overview]
Message-ID: <20171004034311.t3uba7vqcvahly2q@ast-mbp> (raw)
In-Reply-To: <1507087446.8061.37.camel@edumazet-glaptop3.roam.corp.google.com>
On Tue, Oct 03, 2017 at 08:24:06PM -0700, Eric Dumazet wrote:
> On Tue, 2017-10-03 at 19:52 -0700, Alexei Starovoitov wrote:
>
> > yep. looks great.
> > Please test it and submit officially :)
> > The commit aafe6ae9cee3 ("bpf: dynamically allocate digest scratch buffer")
> > fixed the other case where we were relying on the above mutex.
> > The only other spot to be adjusted is to add spin_lock/mutex or DO_ONCE() to
> > bpf_get_skb_set_tunnel_proto() to protect md_dst init.
> > imo that would be it.
> > Daniel, anything else comes to mind?
>
>
> 16 MB of log (unswappable kernel memory) per active checker.
>
> We might offer a way to oom hosts.
right. good point!
we need to switch to continuous copy_to_user() after a page or so.
Can even do it after every vscnprintf()
but page at a time is probably faster.
next prev parent reply other threads:[~2017-10-04 3:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 23:11 [PATCH net-next v2 0/3] tools: add bpftool Jakub Kicinski
2017-10-02 23:11 ` [PATCH net-next v2 1/3] tools: rename tools/net directory to tools/bpf Jakub Kicinski
2017-10-02 23:11 ` [PATCH net-next v2 2/3] tools: bpf: add bpftool Jakub Kicinski
2017-10-02 23:11 ` [PATCH net-next v2 3/3] tools: bpftool: add documentation Jakub Kicinski
2017-10-03 0:55 ` Alexei Starovoitov
2017-10-03 1:35 ` Jakub Kicinski
2017-10-03 4:29 ` Alexei Starovoitov
2017-10-03 15:39 ` David Ahern
2017-10-03 16:01 ` Daniel Borkmann
2017-10-03 16:09 ` David Ahern
2017-10-03 17:57 ` [RFC 1/2] bpf: move instruction printing into a separate file Jakub Kicinski
2017-10-03 17:57 ` [RFC 2/2] tools: bpftool: use the kernel's instruction printer Jakub Kicinski
2017-10-03 19:32 ` [RFC 1/2] bpf: move instruction printing into a separate file Daniel Borkmann
2017-10-03 20:14 ` Alexei Starovoitov
2017-10-04 0:20 ` [RFC] bpf: remove global verifier state Jakub Kicinski
2017-10-04 2:52 ` Alexei Starovoitov
2017-10-04 3:24 ` Eric Dumazet
2017-10-04 3:43 ` Alexei Starovoitov [this message]
2017-10-04 19:13 ` Daniel Borkmann
2017-10-04 21:57 ` Jakub Kicinski
2017-10-04 22:40 ` Alexei Starovoitov
2017-10-03 14:15 ` [PATCH net-next v2 3/3] tools: bpftool: add documentation Daniel Borkmann
2017-10-03 20:19 ` [PATCH net-next v2 0/3] tools: add bpftool Arnaldo Carvalho de Melo
2017-10-04 0:48 ` Jakub Kicinski
2017-10-04 11:40 ` Arnaldo Carvalho de Melo
2017-10-04 4:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004034311.t3uba7vqcvahly2q@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=david.beckett@netronome.com \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).