Re: [PATCH net-next 6/7] net: bridge: Pass extack to down to netdev_master_upper_dev_link

David Ahern
2017-10-04T16:16:19Z

On 10/4/17 8:13 AM, Stephen Hemminger wrote:
> On Tue, 3 Oct 2017 21:58:53 -0700
> David Ahern <dsahern@gmail.com> wrote:
>
>> Pass extack arg to br_add_if. Add messages for a couple of failures
>> and pass arg to netdev_master_upper_dev_link.
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>
> This looks good. You might want to pass the netlink_ext_ack down as
> an immutable pointer (const).

Can't mark extack as const. The NL_SET_ERR_MSG sets _msg to the passed
in string.

>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>