From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [PATCH iproute2 1/3] ss: allow AF_FAMILY constants >32 Date: Wed, 4 Oct 2017 11:01:19 -0400 Message-ID: <20171004150119.GA3840@stefanha-x1.localdomain> References: <20171003175744.24987-1-stefanha@redhat.com> <20171003175744.24987-2-stefanha@redhat.com> <20171003112653.213c7cb3@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Jorgen Hansen , Dexuan Cui To: Stephen Hemminger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44922 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbdJDPBZ (ORCPT ); Wed, 4 Oct 2017 11:01:25 -0400 Content-Disposition: inline In-Reply-To: <20171003112653.213c7cb3@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 03, 2017 at 11:26:53AM -0700, Stephen Hemminger wrote: > On Tue, 3 Oct 2017 13:57:42 -0400 > Stefan Hajnoczi wrote: > > > Linux has more than 32 address families defined in . Use > > a 64-bit type so all of them can be represented in the filter->families > > bitmask. > > > > It's easy to introduce bugs when using (1 << AF_FAMILY) because the > > value is 32-bit. This can produce incorrect results from bitmask > > operations so introduce the FAMILY_MASK() macro to eliminate these bugs. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > misc/ss.c | 54 ++++++++++++++++++++++++++++-------------------------- > > 1 file changed, 28 insertions(+), 26 deletions(-) > > > > diff --git a/misc/ss.c b/misc/ss.c > > index dd8dfaa4..12a31c90 100644 > > --- a/misc/ss.c > > +++ b/misc/ss.c > > @@ -170,55 +170,57 @@ enum { > > struct filter { > > int dbs; > > int states; > > - int families; > > + __u64 families; > > Since this isn't a value that is coming from kernel. It should be uint64_t > rather than __u64. Okay, will fix in v2.