From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next 5/7] net: bonding: Add extack messages for some enslave failures Date: Wed, 4 Oct 2017 20:04:28 +0200 Message-ID: <20171004180428.GG1895@nanopsycho> References: <1507093134-20406-1-git-send-email-dsahern@gmail.com> <1507093134-20406-6-git-send-email-dsahern@gmail.com> <20171004063828.GB1895@nanopsycho> <354fae78-3b04-3807-7392-87c6a3f1b3db@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, jiri@mellanox.com, idosch@mellanox.com, davem@davemloft.net, bridge@lists.linux-foundation.org To: David Ahern Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:52213 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdJDSEb (ORCPT ); Wed, 4 Oct 2017 14:04:31 -0400 Received: by mail-wm0-f65.google.com with SMTP id f4so16721992wme.0 for ; Wed, 04 Oct 2017 11:04:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <354fae78-3b04-3807-7392-87c6a3f1b3db@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Oct 04, 2017 at 05:35:46PM CEST, dsahern@gmail.com wrote: >On 10/3/17 11:38 PM, Jiri Pirko wrote: >> Wed, Oct 04, 2017 at 06:58:52AM CEST, dsahern@gmail.com wrote: >>> A number of bond_enslave errors are logged using the netdev_err API. >>> Return those messages to userspace via the extack facility. >>> >>> Signed-off-by: David Ahern >>> --- >>> drivers/net/bonding/bond_main.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >>> index bc92307c2082..6688dc9154e0 100644 >>> --- a/drivers/net/bonding/bond_main.c >>> +++ b/drivers/net/bonding/bond_main.c >>> @@ -1348,12 +1348,15 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev, >>> >>> /* already in-use? */ >>> if (netdev_is_rx_handler_busy(slave_dev)) { >>> + NL_SET_ERR_MSG(extack, >>> + "Device is in use and cannot be enslaved"); >> >> Please don't do this kind of wrapping. Just let the string be on the >> same line. >> > >Ok, I will do that for bonding only since it is the existing style. I don't believe you need to do this wrap for any code. Just don't wrap. General code stype says no wrap for strings :)