From: David Miller <davem@davemloft.net>
To: devtimhansen@gmail.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
alexander.levin@one.verizon.com
Subject: Re: [PATCH] net/ipv6: remove unused err variable on icmpv6_push_pending_frames
Date: Thu, 05 Oct 2017 22:18:21 -0700 (PDT) [thread overview]
Message-ID: <20171005.221821.1101136936795374969.davem@davemloft.net> (raw)
In-Reply-To: <20171005194532.GA126147@debian>
From: Tim Hansen <devtimhansen@gmail.com>
Date: Thu, 5 Oct 2017 15:45:32 -0400
> int err is unused by icmpv6_push_pending_frames(), this patch returns removes the variable and returns the function with 0.
>
> git bisect shows this variable has been around since linux has been in git in commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2.
>
> This was found by running make coccicheck M=net/ipv6/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current HEAD as of this patch).
>
> Signed-off-by: Tim Hansen <devtimhansen@gmail.com>
Applied.
prev parent reply other threads:[~2017-10-06 5:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:45 [PATCH] net/ipv6: remove unused err variable on icmpv6_push_pending_frames Tim Hansen
2017-10-06 5:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005.221821.1101136936795374969.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.levin@one.verizon.com \
--cc=devtimhansen@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).