From: Rob Herring <robh@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"David S . Miller" <davem@davemloft.net>,
"Simon Horman" <horms@verge.net.au>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property
Date: Thu, 5 Oct 2017 18:24:51 -0500 [thread overview]
Message-ID: <20171005232451.loogqlkmar6pdrdd@rob-hp-laptop> (raw)
In-Reply-To: <fefd2be3-d47a-f035-5078-090df0fc6318@cogentembedded.com>
On Thu, Sep 28, 2017 at 11:07:38PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote:
>
> > The optional "reset-gpios" property (part of the generic MDIO bus
> > properties) lets us describe the GPIO used for resetting the Ethernet
> > PHY.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index c902261893b913f5..4a6ec1ba32d0bf16 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -52,6 +52,7 @@ Optional properties:
> > AVB_LINK signal.
> > - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is
> > active-low instead of normal active-high.
> > +- reset-gpios: see mdio.txt in the same directory.
>
> Sigh, I can only repeat that was a terrible prop name choice -- when
> applied to a MAC node... what reset does it mean? MAC?
Agreed. This should be in the phy node. Or MDIO at least.
next prev parent reply other threads:[~2017-10-05 23:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 15:53 [PATCH 0/4] ravb: Add PHY reset support Geert Uytterhoeven
2017-09-28 15:53 ` [PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property Geert Uytterhoeven
2017-09-28 20:07 ` Sergei Shtylyov
2017-10-05 23:24 ` Rob Herring [this message]
[not found] ` <1506614014-4398-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2017-09-28 15:53 ` [PATCH 2/4] ravb: Add optional PHY reset during system resume Geert Uytterhoeven
2017-09-28 17:22 ` Florian Fainelli
2017-09-28 18:45 ` Geert Uytterhoeven
2017-09-28 19:21 ` Florian Fainelli
2017-09-30 20:23 ` Sergei Shtylyov
2017-10-01 16:34 ` Florian Fainelli
2017-10-09 9:37 ` Sergei Shtylyov
2017-10-09 12:50 ` Sergei Shtylyov
2017-09-28 15:53 ` [PATCH 3/4] arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset Geert Uytterhoeven
[not found] ` <1506614014-4398-4-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2017-09-28 17:20 ` Florian Fainelli
2017-09-28 15:53 ` [PATCH 4/4] arm64: dts: renesas: ulcb: " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005232451.loogqlkmar6pdrdd@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox