From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org,
mst@redhat.com, jasowang@redhat.com, willemb@google.com
Subject: Re: [PATCH RFC 1/3] tun: ethtool stats
Date: Sat, 07 Oct 2017 00:26:42 +0100 (WEST) [thread overview]
Message-ID: <20171007.002642.1079626333365040708.davem@davemloft.net> (raw)
In-Reply-To: <20171006161245.0f4abb99@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 6 Oct 2017 16:12:45 -0700
> On Fri, 6 Oct 2017 18:37:01 -0400
> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>
>> > It looks like you are just exporting the statistics taht are already
>> > through normal path. The purpose of ethtool stats is to provide
>> > statistics unique to the device, not to repeat what is available throug
>> > ip, ifconfig, etc.
>>
>> A follow-up patch adds non-standard statistics.
>>
>> I included these common ones, because the new zerocopy counters
>> are only interesting in relation to tx_packets.
>>
>> It also seems customary among existing network drivers to include
>> at least these base counters in the ethtool output.
>
> Only some drivers that slipped through before I started noticing.
> Do Not Repeat.
Agreed, that is a bad practice unless it is being done to export
per-queue versions of those standard netdev statistics.
next prev parent reply other threads:[~2017-10-06 23:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 22:25 [PATCH RFC 0/3] tun zerocopy stats Willem de Bruijn
2017-10-06 22:25 ` [PATCH RFC 1/3] tun: ethtool stats Willem de Bruijn
2017-10-06 22:30 ` Stephen Hemminger
2017-10-06 22:37 ` Willem de Bruijn
2017-10-06 23:12 ` Stephen Hemminger
2017-10-06 23:26 ` David Miller [this message]
2017-10-06 22:25 ` [PATCH RFC 2/3] tun: expand ethtool stats with zerocopy Willem de Bruijn
2017-10-06 22:32 ` Willem de Bruijn
2017-10-06 22:25 ` [PATCH RFC 3/3] vhost_net: support tun zerocopy stats Willem de Bruijn
2017-10-10 3:52 ` [PATCH RFC 0/3] " David Miller
2017-10-10 15:29 ` Willem de Bruijn
2017-10-10 17:23 ` Stephen Hemminger
2017-10-10 17:39 ` David Miller
2017-10-10 19:11 ` Willem de Bruijn
2017-10-11 3:15 ` Jason Wang
2017-10-11 21:44 ` Willem de Bruijn
2017-10-12 11:21 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007.002642.1079626333365040708.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).