From: David Miller <davem@davemloft.net>
To: michael.chan@broadcom.com
Cc: jtoppins@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef
Date: Sat, 07 Oct 2017 03:01:03 +0100 (WEST) [thread overview]
Message-ID: <20171007.030103.394881238635414484.davem@davemloft.net> (raw)
In-Reply-To: <CACKFLik-dU=1bouTiHhREt4p5X=cGQFjz3fAjHn_pLJQm4FJ2A@mail.gmail.com>
From: Michael Chan <michael.chan@broadcom.com>
Date: Fri, 6 Oct 2017 18:27:31 -0700
> On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins <jtoppins@redhat.com> wrote:
>> There is no reason to wrap the data structures inside the ifdef.
>
> What's so bad about wrapping unused data structures inside #ifdef?
> These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is
> defined.
Yeah I agree, this ifdef is actually a good way to trap unintentional
usage of those datastructures so it's doubly best to keep the ifdef.
next prev parent reply other threads:[~2017-10-07 2:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 19:48 [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled Jonathan Toppins
2017-10-06 19:48 ` [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef Jonathan Toppins
2017-10-07 1:27 ` Michael Chan
2017-10-07 2:01 ` David Miller [this message]
2017-10-07 1:01 ` [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled Michael Chan
2017-10-07 2:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007.030103.394881238635414484.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jtoppins@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).