From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: adobriyan@gmail.com, netdev@vger.kernel.org,
michael.chan@broadcom.com, saeedm@mellanox.com,
simon.horman@netronome.com, jiri@mellanox.com,
ecree@solarflare.com, vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH] net: make ->ndo_get_phys_port_name accept 32-bit len
Date: Sun, 08 Oct 2017 21:14:55 -0700 (PDT) [thread overview]
Message-ID: <20171008.211455.636113197326702869.davem@davemloft.net> (raw)
In-Reply-To: <20171008182545.171498a2@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Sun, 8 Oct 2017 18:25:45 -0700
> On Sun, 8 Oct 2017 01:19:17 +0300, Alexey Dobriyan wrote:
>> Buffer length passed into this hook is always IFNAMSIZ which is 16.
>>
>> Code savings on x86_64:
>>
>> add/remove: 0/0 grow/shrink: 1/9 up/down: 2/-45 (-43)
>> function old new delta
>> rocker_cmd_get_port_settings_phys_name_proc 179 181 +2
>> rocker_port_get_phys_port_name 62 61 -1
>> mlxsw_sx_port_get_phys_port_name 54 50 -4
>> mlx5e_rep_get_phys_port_name 61 57 -4
>> efx_get_phys_port_name 50 46 -4
>> dsa_slave_get_phys_port_name 54 50 -4
>> bnxt_vf_rep_get_phys_port_name 69 65 -4
>> bnxt_get_phys_port_name 70 65 -5
>> mlxsw_sp_port_get_phys_port_name 116 107 -9
>> nfp_port_get_phys_port_name 180 170 -10
>>
>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> I don't think the gains justify the additional burden on backports.
Yeah I agree, this one is not really worth the pain.
prev parent reply other threads:[~2017-10-09 4:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 22:19 [PATCH] net: make ->ndo_get_phys_port_name accept 32-bit len Alexey Dobriyan
2017-10-09 1:25 ` Jakub Kicinski
2017-10-09 4:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171008.211455.636113197326702869.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=ecree@solarflare.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).