From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@fb.com, ganesh.krishna@microchip.com,
netdev@vger.kernel.org, aditya.shankar@microchip.com,
tglx@linutronix.de, khc@pm.waw.pl
Subject: Re: [PATCH] timer: Remove meaningless .data/.function assignments
Date: Mon, 09 Oct 2017 18:05:55 -0700 (PDT) [thread overview]
Message-ID: <20171009.180555.71645109792027520.davem@davemloft.net> (raw)
In-Reply-To: <20171010001032.GA119829@beast>
From: Kees Cook <keescook@chromium.org>
Date: Mon, 9 Oct 2017 17:10:32 -0700
> Several timer users needlessly reset their .function/.data fields during
> their timer callback, but nothing else changes them. Some users do not
> use their .data field at all. Each instance is removed here.
>
> Cc: Krzysztof Halasa <khc@pm.waw.pl>
> Cc: Aditya Shankar <aditya.shankar@microchip.com>
> Cc: Ganesh Krishna <ganesh.krishna@microchip.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-wireless@vger.kernel.org
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> # for staging
> Acked-by: Krzysztof Halasa <khc@pm.waw.pl> # for wan/hdlc*
> Acked-by: Jens Axboe <axboe@kernel.dk> # for amiflop
> ---
> This should go via the timer/core tree, please. It's been acked by each
> of the maintainers. Thanks!
For networking bits:
Acked-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2017-10-10 1:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 0:10 [PATCH] timer: Remove meaningless .data/.function assignments Kees Cook
2017-10-10 1:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009.180555.71645109792027520.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aditya.shankar@microchip.com \
--cc=axboe@fb.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).