From: David Miller <davem@davemloft.net>
To: devtimhansen@gmail.com
Cc: willemb@google.com, edumazet@google.com, soheil@google.com,
pabeni@redhat.com, elena.reshetova@intel.com, tom@quantonium.net,
Jason@zx2c4.com, fw@strlen.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com
Subject: Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.
Date: Tue, 10 Oct 2017 12:32:52 -0700 (PDT) [thread overview]
Message-ID: <20171010.123252.2026981767835237524.davem@davemloft.net> (raw)
In-Reply-To: <20171009153759.km3lqss7hb72wrze@debian>
From: Tim Hansen <devtimhansen@gmail.com>
Date: Mon, 9 Oct 2017 11:37:59 -0400
> Fix BUG() calls to use BUG_ON(conditional) macros.
>
> This was found using make coccicheck M=net/core on linux next
> tag next-2017092
>
> Signed-off-by: Tim Hansen <devtimhansen@gmail.com>
Althrough there were objections raised, none of them technically
stand up, and this does improve code generation for some
architectures, so I have applied this.
Thanks!
next prev parent reply other threads:[~2017-10-10 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 15:37 [PATCH v2] net/core: Fix BUG to BUG_ON conditionals Tim Hansen
2017-10-09 17:15 ` Alexei Starovoitov
2017-10-09 20:26 ` Levin, Alexander (Sasha Levin)
2017-10-09 23:06 ` Alexei Starovoitov
2017-10-09 23:15 ` Levin, Alexander (Sasha Levin)
2017-10-09 23:23 ` Alexei Starovoitov
2017-10-10 1:14 ` Levin, Alexander (Sasha Levin)
2017-10-09 23:17 ` David Miller
2017-10-10 19:32 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-08 19:17 [PATCH] " Tim Hansen
2017-10-08 20:03 ` [PATCH v2] " Tim Hansen
2017-10-09 4:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010.123252.2026981767835237524.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jason@zx2c4.com \
--cc=alexander.levin@one.verizon.com \
--cc=devtimhansen@gmail.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=soheil@google.com \
--cc=tom@quantonium.net \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).