From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
hannes@cmpxchg.org, cgallek@google.com, tj@kernel.org
Subject: Re: [PATCH net 2/2] net: call cgroup_sk_alloc() earlier in sk_clone_lock()
Date: Tue, 10 Oct 2017 20:24:47 -0700 (PDT) [thread overview]
Message-ID: <20171010.202447.2197911623378045472.davem@davemloft.net> (raw)
In-Reply-To: <20171011021233.24158-2-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 10 Oct 2017 19:12:33 -0700
> If for some reason, the newly allocated child need to be freed,
> we will call cgroup_put() (via sk_free_unlock_clone()) while the
> corresponding cgroup_get() was not yet done, and we will free memory
> too soon.
>
> Fixes: d979a39d7242 ("cgroup: duplicate cgroup reference when cloning sockets")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2017-10-11 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 2:12 [PATCH net 1/2] Revert "net: defer call to cgroup_sk_alloc()" Eric Dumazet
2017-10-11 2:12 ` [PATCH net 2/2] net: call cgroup_sk_alloc() earlier in sk_clone_lock() Eric Dumazet
2017-10-11 3:24 ` David Miller [this message]
2017-10-11 3:24 ` [PATCH net 1/2] Revert "net: defer call to cgroup_sk_alloc()" David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010.202447.2197911623378045472.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cgallek@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).