From: Matthew Wilcox <willy@infradead.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Ian Abbott <abbotti@mev.co.uk>, Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-cachefs@redhat.com, linux-sh@vger.kernel.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
linux-rdma@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Tariq Toukan <tariqt@mellanox.com>, Rich Felker <dalias@libc.org>,
Leon Romanovsky <leonro@mellanox.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
David Howells <dhowells@redhat.com>,
intel-gfx@lists.freedesktop.org,
Yishai Hadas <yishaih@mellanox.com>,
Joonas La
Subject: Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to <linux/radix-tree-root.h>
Date: Tue, 10 Oct 2017 05:18:30 -0700 [thread overview]
Message-ID: <20171010121829.GA26493@bombadil.infradead.org> (raw)
In-Reply-To: <1507479013-5207-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote:
> Reducing the header dependency will help for speeding the kernel
> build, suppressing unnecessary recompile of objects during
> git-bisect'ing, etc.
Well, does it? You could provide measurements showing before/after
time to compile, or time to recompile after touching a header file that
is included by radix-tree.h and not by radix-tree-root.h.
Look at the files included (never mind the transitively included files):
#include <linux/bitops.h>
#include <linux/bug.h>
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/preempt.h>
#include <linux/rcupdate.h>
#include <linux/spinlock.h>
#include <linux/types.h>
These are not exactly rare files to be included. My guess is that most
of the files in the kernel end up depending on these files *anyway*, either
directly or through some path that isn't the radix tree.
next prev parent reply other threads:[~2017-10-10 12:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 16:10 [PATCH 00/12] radix-tree: split out struct radix_tree_root out to <linux/radix-tree-root.h> Masahiro Yamada
2017-10-08 16:10 ` [PATCH 10/12] net/mlx4: replace <linux/radix-tree.h> with <linux/radix-tree-root.h> Masahiro Yamada
2017-10-08 17:00 ` David Miller
2017-10-08 17:29 ` Masahiro Yamada
2017-10-08 17:32 ` Joe Perches
[not found] ` <1507483942.11434.4.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-10-09 5:55 ` Masahiro Yamada
2017-10-09 12:02 ` Masahiro Yamada
2017-10-08 18:55 ` Leon Romanovsky
2017-10-09 5:56 ` Masahiro Yamada
[not found] ` <CAK7LNARAhAaO+YjqXyBbi=-udCu8zzGnLMsoVNdkSXtXPuMKsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-09 6:10 ` Leon Romanovsky
2017-10-08 16:10 ` [PATCH 11/12] net/mlx5: " Masahiro Yamada
2017-10-08 17:00 ` David Miller
[not found] ` <1507479013-5207-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-10-08 18:52 ` [PATCH 00/12] radix-tree: split out struct radix_tree_root out to <linux/radix-tree-root.h> Leon Romanovsky
2017-10-09 5:58 ` Masahiro Yamada
2017-10-09 6:05 ` Leon Romanovsky
2017-10-10 12:18 ` Matthew Wilcox [this message]
2017-10-10 12:56 ` Masahiro Yamada
2017-10-10 13:20 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010121829.GA26493@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=abbotti@mev.co.uk \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dalias@libc.org \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=leonro@mellanox.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tariqt@mellanox.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
--cc=yishaih@mellanox.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).