From: David Miller <davem@davemloft.net>
To: joel@jms.id.au
Cc: benh@kernel.crashing.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew@aj.id.au
Subject: Re: [PATCH] net: ftgmac100: Request clock and set speed
Date: Wed, 11 Oct 2017 12:08:51 -0700 (PDT) [thread overview]
Message-ID: <20171011.120851.1428660689178106234.davem@davemloft.net> (raw)
In-Reply-To: <20171010044925.21078-1-joel@jms.id.au>
From: Joel Stanley <joel@jms.id.au>
Date: Tue, 10 Oct 2017 15:19:25 +1030
> According to the ASPEED datasheet, gigabit speeds require a clock of
> 100MHz or higher. Other speeds require 25MHz or higher.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Hey Joel, it seems that Benjamin would like you to guard this new
logic with whether we have an aspeed configuration or not.
Thank you.
prev parent reply other threads:[~2017-10-11 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 4:49 [PATCH] net: ftgmac100: Request clock and set speed Joel Stanley
2017-10-10 5:04 ` Florian Fainelli
2017-10-10 5:08 ` Joel Stanley
2017-10-10 8:14 ` Benjamin Herrenschmidt
2017-10-12 3:02 ` Joel Stanley
2017-10-11 19:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011.120851.1428660689178106234.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).