From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ynorov@caviumnetworks.com, netdev@vger.kernel.org,
catalin.marinas@arm.com, weiwan@google.com, ncardwell@google.com
Subject: Re: [PATCH net-next] tcp: fix tcp_unlink_write_queue()
Date: Wed, 11 Oct 2017 13:41:14 -0700 (PDT) [thread overview]
Message-ID: <20171011.134114.1377805651978859991.davem@davemloft.net> (raw)
In-Reply-To: <1507753649.31614.36.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 11 Oct 2017 13:27:29 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Yury reported crash with this signature :
>
> [ 554.034021] [<ffff80003ccd5a58>] 0xffff80003ccd5a58
> [ 554.034156] [<ffff00000888fd34>] skb_release_all+0x14/0x30
> [ 554.034288] [<ffff00000888fd64>] __kfree_skb+0x14/0x28
> [ 554.034409] [<ffff0000088ece6c>] tcp_sendmsg_locked+0x4dc/0xcc8
> [ 554.034541] [<ffff0000088ed68c>] tcp_sendmsg+0x34/0x58
> [ 554.034659] [<ffff000008919fd4>] inet_sendmsg+0x2c/0xf8
> [ 554.034783] [<ffff0000088842e8>] sock_sendmsg+0x18/0x30
> [ 554.034928] [<ffff0000088861fc>] SyS_sendto+0x84/0xf8
>
> Problem is that skb->destructor contains garbage, and this is
> because I accidentally removed tcp_skb_tsorted_anchor_cleanup()
> from tcp_unlink_write_queue()
>
> This would trigger with a write(fd, <invalid_memory>, len) attempt,
> and we will add to packetdrill this capability to avoid future
> regressions.
>
> Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue")
> Reported-by: Yury Norov <ynorov@caviumnetworks.com>
> Tested-by: Yury Norov <ynorov@caviumnetworks.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2017-10-11 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 18:35 next: arm64: LTP sendto01 test causes system crash in ilp32 mode Yury Norov
2017-10-11 18:41 ` Eric Dumazet
2017-10-11 18:48 ` Eric Dumazet
2017-10-11 19:43 ` Yury Norov
2017-10-11 20:27 ` [PATCH net-next] tcp: fix tcp_unlink_write_queue() Eric Dumazet
2017-10-11 20:41 ` David Miller [this message]
2017-10-11 20:28 ` next: arm64: LTP sendto01 test causes system crash in ilp32 mode Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011.134114.1377805651978859991.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=catalin.marinas@arm.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).