* [PATCH 1/3] atm: idt77105: Drop needless setup_timer()
[not found] <1507663550-13343-1-git-send-email-keescook@chromium.org>
@ 2017-10-10 19:25 ` Kees Cook
2017-10-11 21:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2017-10-10 19:25 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Kees Cook, Chas Williams, linux-atm-general, netdev, linux-kernel
Calling setup_timer() is redundant when DEFINE_TIMER() has been used.
Cc: Chas Williams <3chas3@gmail.com>
Cc: linux-atm-general@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
This is intended to go via the timer tree. Acks appreciated!
---
drivers/atm/idt77105.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/atm/idt77105.c b/drivers/atm/idt77105.c
index 57af9fd198e4..909744eb7bab 100644
--- a/drivers/atm/idt77105.c
+++ b/drivers/atm/idt77105.c
@@ -306,11 +306,9 @@ static int idt77105_start(struct atm_dev *dev)
if (start_timer) {
start_timer = 0;
- setup_timer(&stats_timer, idt77105_stats_timer_func, 0UL);
stats_timer.expires = jiffies+IDT77105_STATS_TIMER_PERIOD;
add_timer(&stats_timer);
- setup_timer(&restart_timer, idt77105_restart_timer_func, 0UL);
restart_timer.expires = jiffies+IDT77105_RESTART_TIMER_PERIOD;
add_timer(&restart_timer);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] atm: idt77105: Drop needless setup_timer()
2017-10-10 19:25 ` [PATCH 1/3] atm: idt77105: Drop needless setup_timer() Kees Cook
@ 2017-10-11 21:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-10-11 21:15 UTC (permalink / raw)
To: keescook; +Cc: tglx, 3chas3, linux-atm-general, netdev, linux-kernel
From: Kees Cook <keescook@chromium.org>
Date: Tue, 10 Oct 2017 12:25:48 -0700
> Calling setup_timer() is redundant when DEFINE_TIMER() has been used.
>
> Cc: Chas Williams <3chas3@gmail.com>
> Cc: linux-atm-general@lists.sourceforge.net
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-11 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1507663550-13343-1-git-send-email-keescook@chromium.org>
2017-10-10 19:25 ` [PATCH 1/3] atm: idt77105: Drop needless setup_timer() Kees Cook
2017-10-11 21:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).