* [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static
@ 2017-10-11 9:53 Colin King
2017-10-11 14:12 ` David Ahern
2017-10-12 3:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-10-11 9:53 UTC (permalink / raw)
To: David S . Miller, David Ahern, Robert Shearman, Roopa Prabhu,
netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function ipgre_mpls_encap_hlen is local to the source and
does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/mpls/af_mpls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 9745e8f69810..8ca9915befc8 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -41,7 +41,7 @@ static int label_limit = (1 << 20) - 1;
static int ttl_max = 255;
#if IS_ENABLED(CONFIG_NET_IP_TUNNEL)
-size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
+static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
{
return sizeof(struct mpls_shim_hdr);
}
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static
2017-10-11 9:53 [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static Colin King
@ 2017-10-11 14:12 ` David Ahern
2017-10-12 3:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2017-10-11 14:12 UTC (permalink / raw)
To: Colin King, David S . Miller, Robert Shearman, Roopa Prabhu,
netdev
Cc: kernel-janitors, linux-kernel, Amine Kherbouche
On 10/11/17 3:53 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function ipgre_mpls_encap_hlen is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static?
>
Fixes: bdc476413dcdb ("ip_tunnel: add mpls over gre support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/mpls/af_mpls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index 9745e8f69810..8ca9915befc8 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -41,7 +41,7 @@ static int label_limit = (1 << 20) - 1;
> static int ttl_max = 255;
>
> #if IS_ENABLED(CONFIG_NET_IP_TUNNEL)
> -size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
> +static size_t ipgre_mpls_encap_hlen(struct ip_tunnel_encap *e)
> {
> return sizeof(struct mpls_shim_hdr);
> }
>
Acked-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static
2017-10-11 9:53 [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static Colin King
2017-10-11 14:12 ` David Ahern
@ 2017-10-12 3:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-10-12 3:20 UTC (permalink / raw)
To: colin.king
Cc: dsahern, rshearma, roopa, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 11 Oct 2017 10:53:28 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The function ipgre_mpls_encap_hlen is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks Colin.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-12 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 9:53 [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static Colin King
2017-10-11 14:12 ` David Ahern
2017-10-12 3:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).