From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: k.eugene.e@gmail.com, kvalo@codeaurora.org,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
Date: Tue, 10 Oct 2017 23:54:45 -0700 [thread overview]
Message-ID: <20171011065445.GP1165@minitux> (raw)
In-Reply-To: <1507467969-24016-1-git-send-email-baijiaju1990@163.com>
On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote:
> No rcu_read_lock is called, but rcu_read_unlock is still called.
> Thus rcu_read_unlock should be removed.
>
Thanks, not sure how I could miss that one. Kalle can you please include
this in a v4.14-rc pull request?
:
Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration")
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 35bd50b..b83f01d 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
> if (!sta) {
> wcn36xx_err("sta %pM is not found\n",
> bss_conf->bssid);
> - rcu_read_unlock();
> goto out;
> }
> sta_priv = wcn36xx_sta_to_priv(sta);
> --
> 1.7.9.5
>
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx
next prev parent reply other threads:[~2017-10-11 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 13:06 [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Jia-Ju Bai
2017-10-11 6:54 ` Bjorn Andersson [this message]
2017-10-11 8:28 ` Kalle Valo
[not found] ` <1507467969-24016-1-git-send-email-baijiaju1990-9Onoh4P/yGk@public.gmane.org>
2017-10-27 14:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011065445.GP1165@minitux \
--to=bjorn.andersson@linaro.org \
--cc=baijiaju1990@163.com \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).