From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org, parthasarathy.bhuvaragan@ericsson.com,
ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net
Subject: Re: [net-next 04/18] tipc: refactor function filter_rcv()
Date: Thu, 12 Oct 2017 11:56:13 -0700 (PDT) [thread overview]
Message-ID: <20171012.115613.907390207015671199.davem@davemloft.net> (raw)
In-Reply-To: <1507816959-31787-5-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Thu, 12 Oct 2017 16:02:25 +0200
> +static void tipc_sk_proto_rcv(struct sock *sk,
> + struct sk_buff_head *inputq,
> + struct sk_buff_head *xmitq)
> +{
> + struct tipc_sock *tsk = tipc_sk(sk);
> + struct sk_buff *skb = __skb_dequeue(inputq);
> + struct tipc_msg *hdr = buf_msg(skb);
Please order local variables from longest to shortest line.
next prev parent reply other threads:[~2017-10-12 18:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 14:02 [net-next 00/18] tipc: Introduce Communcation Group feature Jon Maloy
2017-10-12 14:02 ` [net-next 01/18] tipc: add ability to order and receive topology events in driver Jon Maloy
2017-10-12 18:54 ` David Miller
2017-10-12 14:02 ` [net-next 02/18] tipc: improve address sanity check in tipc_connect() Jon Maloy
2017-10-12 14:02 ` [net-next 03/18] tipc: add ability to obtain node availability status from other files Jon Maloy
2017-10-12 14:02 ` [net-next 04/18] tipc: refactor function filter_rcv() Jon Maloy
2017-10-12 18:56 ` David Miller [this message]
2017-10-12 14:02 ` [net-next 05/18] tipc: add new function for sending multiple small messages Jon Maloy
2017-10-12 14:02 ` [net-next 06/18] tipc: improve destination linked list Jon Maloy
2017-10-12 18:57 ` David Miller
2017-10-12 14:02 ` [net-next 07/18] tipc: introduce communication groups Jon Maloy
2017-10-12 14:02 ` [net-next 08/18] tipc: add second source address to recvmsg()/recvfrom() Jon Maloy
2017-10-12 14:02 ` [net-next 09/18] tipc: receive group membership events via member socket Jon Maloy
2017-10-12 14:02 ` [net-next 10/18] tipc: introduce flow control for group broadcast messages Jon Maloy
2017-10-12 14:02 ` [net-next 11/18] tipc: introduce group unicast messaging Jon Maloy
2017-10-12 14:02 ` [net-next 12/18] tipc: introduce group anycast messaging Jon Maloy
2017-10-12 14:02 ` [net-next 13/18] tipc: introduce group multicast messaging Jon Maloy
2017-10-12 14:02 ` [net-next 14/18] tipc: guarantee group unicast doesn't bypass group broadcast Jon Maloy
2017-10-12 14:02 ` [net-next 15/18] tipc: guarantee that group broadcast doesn't bypass group unicast Jon Maloy
2017-10-12 14:02 ` [net-next 16/18] tipc: guarantee delivery of UP event before first broadcast Jon Maloy
2017-10-12 14:02 ` [net-next 17/18] tipc: guarantee delivery of last broadcast before DOWN event Jon Maloy
2017-10-12 14:02 ` [net-next 18/18] tipc: add multipoint-to-point flow control Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012.115613.907390207015671199.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=parthasarathy.bhuvaragan@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).