From: David Miller <davem@davemloft.net>
To: aring@mojatatu.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org, eric.dumazet@gmail.com, bjb@mojatatu.com
Subject: Re: [PATCH net-next 0/3] sched: act: ife: UAPI checks and performance tweaks
Date: Thu, 12 Oct 2017 22:23:17 -0700 (PDT) [thread overview]
Message-ID: <20171012.222317.639552348780320377.davem@davemloft.net> (raw)
In-Reply-To: <20171011211608.22692-1-aring@mojatatu.com>
From: Alexander Aring <aring@mojatatu.com>
Date: Wed, 11 Oct 2017 17:16:05 -0400
> this patch series contains at first a patch which adds a check for
> IFE_ENCODE and IFE_DECODE when a ife act gets created or updated and adding
> handling of these cases only inside the act callback only.
>
> The second patch use per-cpu counters and move the spinlock around so that
> the spinlock is less being held in act callback.
>
> The last patch use rcu for update parameters and also move the spinlock for
> the same purpose as in patch 2.
>
> Notes:
> - There is still a spinlock around for protecting the metalist and a
> rw-lock for another list. Should be migrated to a rcu list, ife
> possible.
>
> - I use still dereference in dump callback, so I think what I didn't
> got was what happened when rcu_assign_pointer will do when rcu read
> lock is held. I suppose the pointer will be updated, then we don't
> have any issue here.
Series applied.
prev parent reply other threads:[~2017-10-13 5:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 21:16 [PATCH net-next 0/3] sched: act: ife: UAPI checks and performance tweaks Alexander Aring
2017-10-11 21:16 ` [PATCH net-next 1/3] sched: act: ife: move encode/decode check to init Alexander Aring
2017-10-13 1:38 ` Jamal Hadi Salim
2017-10-11 21:16 ` [PATCH net-next 2/3] sched: act: ife: migrate to use per-cpu counters Alexander Aring
2017-10-13 1:39 ` Jamal Hadi Salim
2017-10-11 21:16 ` [PATCH net-next 3/3] sched: act: ife: update parameters via rcu handling Alexander Aring
2017-10-13 1:39 ` Jamal Hadi Salim
2017-10-13 5:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012.222317.639552348780320377.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aring@mojatatu.com \
--cc=bjb@mojatatu.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).