* [PATCH] net: stmmac: dwmac_lib: fix interchanged sleep/timeout values in DMA reset function
@ 2017-10-12 9:00 Emiliano Ingrassia
2017-10-13 17:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Emiliano Ingrassia @ 2017-10-12 9:00 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, netdev
The DMA reset timeout, used in read_poll_timeout, is
ten times shorter than the sleep time.
This patch fixes these values interchanging them, as it was
before the read_poll_timeout introduction.
Fixes: 8a70aeca80c2 ("net: stmmac: Use readl_poll_timeout")
Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
index 67af0bdd7f10..7516ca210855 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
@@ -34,7 +34,7 @@ int dwmac_dma_reset(void __iomem *ioaddr)
err = readl_poll_timeout(ioaddr + DMA_BUS_MODE, value,
!(value & DMA_BUS_MODE_SFT_RESET),
- 100000, 10000);
+ 10000, 100000);
if (err)
return -EBUSY;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: stmmac: dwmac_lib: fix interchanged sleep/timeout values in DMA reset function
2017-10-12 9:00 [PATCH] net: stmmac: dwmac_lib: fix interchanged sleep/timeout values in DMA reset function Emiliano Ingrassia
@ 2017-10-13 17:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-10-13 17:20 UTC (permalink / raw)
To: ingrassia; +Cc: peppe.cavallaro, alexandre.torgue, netdev
From: Emiliano Ingrassia <ingrassia@epigenesys.com>
Date: Thu, 12 Oct 2017 11:00:47 +0200
> The DMA reset timeout, used in read_poll_timeout, is
> ten times shorter than the sleep time.
> This patch fixes these values interchanging them, as it was
> before the read_poll_timeout introduction.
>
> Fixes: 8a70aeca80c2 ("net: stmmac: Use readl_poll_timeout")
>
> Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 9:00 [PATCH] net: stmmac: dwmac_lib: fix interchanged sleep/timeout values in DMA reset function Emiliano Ingrassia
2017-10-13 17:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).