From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] tracing: bpf: Hide bpf trace events when they are not used
Date: Thu, 12 Oct 2017 18:14:52 -0700 [thread overview]
Message-ID: <20171013011450.w2uqygdfzwf7ud64@ast-mbp> (raw)
In-Reply-To: <20171012184002.0661a867@gandalf.local.home>
On Thu, Oct 12, 2017 at 06:40:02PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> All the trace events defined in include/trace/events/bpf.h are only
> used when CONFIG_BPF_SYSCALL is defined. But this file gets included by
> include/linux/bpf_trace.h which is included by the networking code with
> CREATE_TRACE_POINTS defined.
>
> If a trace event is created but not used it still has data structures
> and functions created for its use, even though nothing is using them.
> To not waste space, do not define the BPF trace events in bpf.h unless
> CONFIG_BPF_SYSCALL is defined.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Looks fine.
Acked-by: Alexei Starovoitov <ast@kernel.org>
I'm assuming you want to take it through tracing tree along
with all other cleanups?
next prev parent reply other threads:[~2017-10-13 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:40 [PATCH] tracing: bpf: Hide bpf trace events when they are not used Steven Rostedt
2017-10-13 1:14 ` Alexei Starovoitov [this message]
2017-10-13 1:35 ` Steven Rostedt
2017-10-13 1:38 ` Alexei Starovoitov
2017-10-13 1:49 ` Steven Rostedt
2017-10-16 19:54 ` David Miller
2017-10-16 20:01 ` Steven Rostedt
2017-10-16 20:11 ` David Miller
2017-10-16 20:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013011450.w2uqygdfzwf7ud64@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox