* [PATCH] nfp: Explicitly include linux/bug.h
@ 2017-10-13 2:50 Mark Brown
2017-10-13 3:16 ` Jakub Kicinski
2017-10-15 1:31 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2017-10-13 2:50 UTC (permalink / raw)
To: davem, Jakub Kicinski, Simon Horman; +Cc: oss-drivers, netdev, Mark Brown
Today's -next build encountered an error due to a missing definition of
WARN_ON(), caused by some header reorganization removing an implicit
inclusion of linux/bug.h. Fix this with an explicit inclusion.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/net/ethernet/netronome/nfp/nfp_app.c | 1 +
drivers/net/ethernet/netronome/nfp/nfp_asm.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_app.c b/drivers/net/ethernet/netronome/nfp/nfp_app.c
index 82c290763529..5d9e2eba5b49 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_app.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_app.c
@@ -31,6 +31,7 @@
* SOFTWARE.
*/
+#include <linux/bug.h>
#include <linux/skbuff.h>
#include <linux/slab.h>
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_asm.h b/drivers/net/ethernet/netronome/nfp/nfp_asm.h
index c4c18dd5630a..aa397bf308e4 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_asm.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_asm.h
@@ -35,6 +35,7 @@
#define __NFP_ASM_H__ 1
#include <linux/bitfield.h>
+#include <linux/bug.h>
#include <linux/types.h>
#define REG_NONE 0
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: Explicitly include linux/bug.h
2017-10-13 2:50 [PATCH] nfp: Explicitly include linux/bug.h Mark Brown
@ 2017-10-13 3:16 ` Jakub Kicinski
2017-10-15 1:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2017-10-13 3:16 UTC (permalink / raw)
To: Mark Brown; +Cc: davem, Simon Horman, oss-drivers, netdev
On Fri, 13 Oct 2017 03:50:35 +0100, Mark Brown wrote:
> Today's -next build encountered an error due to a missing definition of
> WARN_ON(), caused by some header reorganization removing an implicit
> inclusion of linux/bug.h. Fix this with an explicit inclusion.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: Explicitly include linux/bug.h
2017-10-13 2:50 [PATCH] nfp: Explicitly include linux/bug.h Mark Brown
2017-10-13 3:16 ` Jakub Kicinski
@ 2017-10-15 1:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-10-15 1:31 UTC (permalink / raw)
To: broonie; +Cc: jakub.kicinski, simon.horman, oss-drivers, netdev
From: Mark Brown <broonie@kernel.org>
Date: Fri, 13 Oct 2017 03:50:35 +0100
> Today's -next build encountered an error due to a missing definition of
> WARN_ON(), caused by some header reorganization removing an implicit
> inclusion of linux/bug.h. Fix this with an explicit inclusion.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Applied, thanks Mark.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-15 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 2:50 [PATCH] nfp: Explicitly include linux/bug.h Mark Brown
2017-10-13 3:16 ` Jakub Kicinski
2017-10-15 1:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).