From: Andrew Lunn <andrew@lunn.ch>
To: jacopo mondi <jacopo@jmondi.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Chris Brandt <Chris.Brandt@renesas.com>,
f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group
Date: Sat, 14 Oct 2017 17:13:32 +0200 [thread overview]
Message-ID: <20171014151332.GD12454@lunn.ch> (raw)
In-Reply-To: <20171006122445.GA30375@w540>
> > So your binding whats to look something like
> >
> > ether: ethernet@e8203000 {
> > compatible = "renesas,ether-r7s72100";
> > reg = <0xe8203000 0x800>,
> > <0xe8204800 0x200>;
> > interrupts = <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&mstp7_clks R7S72100_CLK_ETHER>;
> > power-domains = <&cpg_clocks>;
> > phy-mode = "mii";
> > phy-handle = <&phy0>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > mdio: bus-bus {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > phy0: ethernet-phy@1 {
> > reg = <1>;
>
> Why reg = <1> ?
> Shouldn't this be 0, or even better with no reg property at all?
This is the address of the PHY on the MDIO bus. There can be up to 32
devices on the bus. I have no idea what address your PHY is using, so
i just picked a value. 0 can be special, so i avoided it.
Andrew
prev parent reply other threads:[~2017-10-14 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1507193900-23801-1-git-send-email-jacopo+renesas@jmondi.org>
[not found] ` <1507193900-23801-4-git-send-email-jacopo+renesas@jmondi.org>
[not found] ` <CAMuHMdWLt9EYp21YiMp7uEGWgjEO_VztbDOyvhr+RxkrAKRYYA@mail.gmail.com>
2017-10-05 9:39 ` [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group jacopo mondi
2017-10-05 13:43 ` Andrew Lunn
2017-10-05 15:42 ` jacopo mondi
2017-10-05 16:48 ` Andrew Lunn
2017-10-06 12:24 ` jacopo mondi
2017-10-14 15:13 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171014151332.GD12454@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Brandt@renesas.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).